Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040832
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 05. Production managementminorhave not tried2019-04-10 11:412019-06-05 15:54
ReportershuehnerView Statuspublic 
Assigned Tononofrancisco 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q2.1
StatusclosedFix in branchFixed in SCM revision785a223ac67f
ProjectionnoneETAnoneTarget Version3.0PR19Q2.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040832: SequenceProductCreate.getLineNum is not using bind-parameters

DescriptionThis code is not using bind-params:

    String hql = " SELECT COALESCE(MAX(l.lineNo),0)+10 AS DefaultValue FROM ManufacturingOperationProduct l WHERE l.mASequence.id= '"
        + SequenceId + "'";
    Query<Long> q = OBDal.getInstance().getSession().createQuery(hql, Long.class);
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 00405743.0PR19Q3 closednonofrancisco SequenceProductCreate.getLineNum is not using bind-parameters 

-  Notes
(0112426)
hgbot (developer)
2019-06-05 15:53

Repository: erp/backports/3.0PR19Q2.1
Changeset: 785a223ac67f4cb4144410f9185f243831b4510c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed May 01 22:53:24 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/785a223ac67f4cb4144410f9185f243831b4510c [^]

Fixes issue 40832: Uses bind parameter.

Instead of string concatenation, bind parameter is used to build the query.

---
M src/org/openbravo/erpCommon/ad_actionButton/SequenceProductCreate.java
---
(0112428)
Sandrahuguet (developer)
2019-06-05 15:54

code review + testing ok

- Issue History
Date Modified Username Field Change
2019-05-09 23:25 nonofrancisco Type defect => backport
2019-05-09 23:25 nonofrancisco Target Version => 3.0PR19Q2
2019-05-10 08:12 Sandrahuguet Target Version 3.0PR19Q2 => 3.0PR19Q2.1
2019-06-05 15:53 hgbot Checkin
2019-06-05 15:53 hgbot Note Added: 0112426
2019-06-05 15:53 hgbot Status scheduled => resolved
2019-06-05 15:53 hgbot Resolution open => fixed
2019-06-05 15:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/785a223ac67f4cb4144410f9185f243831b4510c [^]
2019-06-05 15:54 Sandrahuguet Review Assigned To => Sandrahuguet
2019-06-05 15:54 Sandrahuguet Note Added: 0112428
2019-06-05 15:54 Sandrahuguet Status resolved => closed
2019-06-05 15:54 Sandrahuguet Fixed in Version => 3.0PR19Q2.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker