Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040832Openbravo ERP05. Production managementpublic2019-04-10 11:412019-06-05 15:54
Reportershuehner 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q2.1Fixed in Version3.0PR19Q2.1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040832: SequenceProductCreate.getLineNum is not using bind-parameters
DescriptionThis code is not using bind-params:

    String hql = " SELECT COALESCE(MAX(l.lineNo),0)+10 AS DefaultValue FROM ManufacturingOperationProduct l WHERE l.mASequence.id= '"
        + SequenceId + "'";
    Query<Long> q = OBDal.getInstance().getSession().createQuery(hql, Long.class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00405743.0PR19Q3 closed nonofrancisco SequenceProductCreate.getLineNum is not using bind-parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-09 23:25nonofranciscoTypedefect => backport
2019-05-09 23:25nonofranciscoTarget Version => 3.0PR19Q2
2019-05-10 08:12SandrahuguetTarget Version3.0PR19Q2 => 3.0PR19Q2.1
2019-06-05 15:53hgbotCheckin
2019-06-05 15:53hgbotNote Added: 0112426
2019-06-05 15:53hgbotStatusscheduled => resolved
2019-06-05 15:53hgbotResolutionopen => fixed
2019-06-05 15:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/785a223ac67f4cb4144410f9185f243831b4510c [^]
2019-06-05 15:54SandrahuguetReview Assigned To => Sandrahuguet
2019-06-05 15:54SandrahuguetNote Added: 0112428
2019-06-05 15:54SandrahuguetStatusresolved => closed
2019-06-05 15:54SandrahuguetFixed in Version => 3.0PR19Q2.1

Notes
(0112426)
hgbot   
2019-06-05 15:53   
Repository: erp/backports/3.0PR19Q2.1
Changeset: 785a223ac67f4cb4144410f9185f243831b4510c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed May 01 22:53:24 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/785a223ac67f4cb4144410f9185f243831b4510c [^]

Fixes issue 40832: Uses bind parameter.

Instead of string concatenation, bind parameter is used to build the query.

---
M src/org/openbravo/erpCommon/ad_actionButton/SequenceProductCreate.java
---
(0112428)
Sandrahuguet   
2019-06-05 15:54   
code review + testing ok