0040773: SL_TaxCategory_Org.execute is not using bind-parameters

Description

This method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040559

closed

nonofrancisco

SL_TaxCategory_Org.execute is not using bind-parameters

Notes
(0111610) hgbot (developer) 2019-05-10 08:35	Repository: erp/backports/3.0PR19Q1.2 Changeset: 67da70fbfe160250c8d1f0c2a4e05e3424021f8c Author: Nono Carballo <nonofce <at> gmail.com> Date: Mon Apr 22 15:04:05 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/67da70fbfe160250c8d1f0c2a4e05e3424021f8c [^] Fixes issue 40773: Uses bind parameters in query Instead of using string concatenation in client and organization filters in where clause, bind parameters are used --- M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java ---

(0111612) Sandrahuguet (developer) 2019-05-10 08:38	code review + testing ok

Issue History
Date Modified	Username	Field	Change
2019-05-04 16:55	nonofrancisco	Type	defect => backport
2019-05-04 16:55	nonofrancisco	Target Version	=> 3.0PR19Q1.1
2019-05-06 08:31	Sandrahuguet	Target Version	3.0PR19Q1.1 => 3.0PR19Q1.2
2019-05-10 08:35	hgbot	Checkin
2019-05-10 08:35	hgbot	Note Added: 0111610
2019-05-10 08:35	hgbot	Status	scheduled => resolved
2019-05-10 08:35	hgbot	Resolution	open => fixed
2019-05-10 08:35	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/67da70fbfe160250c8d1f0c2a4e05e3424021f8c [^]
2019-05-10 08:38	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2019-05-10 08:38	Sandrahuguet	Note Added: 0111612
2019-05-10 08:38	Sandrahuguet	Status	resolved => closed
2019-05-10 08:38	Sandrahuguet	Fixed in Version	=> 3.0PR19Q1.2