Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040773Openbravo ERP07. Sales managementpublic2019-04-09 20:292019-05-10 08:38
Reportershuehner 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.2Fixed in Version3.0PR19Q1.2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040773: SL_TaxCategory_Org.execute is not using bind-parameters
DescriptionThis method is not using bind-parameters in lines 49 + 58

      whereClause = "as tn where tn.node = '" + organization.getId() + "' and tn.client.id = '"
          + organization.getClient().getId() + "'";

        OBQuery<TreeNode> query = OBDal.getInstance().createQuery(TreeNode.class, whereClause);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040559 closed nonofrancisco SL_TaxCategory_Org.execute is not using bind-parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-04 16:55nonofranciscoTypedefect => backport
2019-05-04 16:55nonofranciscoTarget Version => 3.0PR19Q1.1
2019-05-06 08:31SandrahuguetTarget Version3.0PR19Q1.1 => 3.0PR19Q1.2
2019-05-10 08:35hgbotCheckin
2019-05-10 08:35hgbotNote Added: 0111610
2019-05-10 08:35hgbotStatusscheduled => resolved
2019-05-10 08:35hgbotResolutionopen => fixed
2019-05-10 08:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/67da70fbfe160250c8d1f0c2a4e05e3424021f8c [^]
2019-05-10 08:38SandrahuguetReview Assigned To => Sandrahuguet
2019-05-10 08:38SandrahuguetNote Added: 0111612
2019-05-10 08:38SandrahuguetStatusresolved => closed
2019-05-10 08:38SandrahuguetFixed in Version => 3.0PR19Q1.2

Notes
(0111610)
hgbot   
2019-05-10 08:35   
Repository: erp/backports/3.0PR19Q1.2
Changeset: 67da70fbfe160250c8d1f0c2a4e05e3424021f8c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Apr 22 15:04:05 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/67da70fbfe160250c8d1f0c2a4e05e3424021f8c [^]

Fixes issue 40773: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used

---
M src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java
---
(0111612)
Sandrahuguet   
2019-05-10 08:38   
code review + testing ok