Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040571
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2019-04-10 11:252019-06-24 10:58
ReportershuehnerView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision610941ce811b
ProjectionnoneETAnoneTarget VersionRR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040571: ServerStateBackground.getServerstoSendPing is not using bind-parameters

DescriptionThis code is not using bind-params:
    OBQuery<MobileServerDefinition> serversQry = OBDal.getInstance()
        .createQuery(MobileServerDefinition.class,
            "client.id=:clientId and " + MobileServerDefinition.PROPERTY_MOBILESERVERKEY + "!='"
                + thisServerDef.getMobileServerKey() + "' and "
                + MobileServerDefinition.PROPERTY_SERVERTYPE + "='" + MobileServerUtils.STORE_SERVER
                + "'" + " order by " + MobileServerDefinition.PROPERTY_PRIORITY);
Steps To Reproduce-
TagsNo tags attached.
Attached Filespatch file icon issue 40571 source mobilecore.patch [^] (2,008 bytes) 2019-05-16 09:05 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0112939)
hgbot (developer)
2019-06-21 13:18

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 610941ce811b7121724c3283b70352fddaa53eb9
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 21 11:33:46 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/610941ce811b7121724c3283b70352fddaa53eb9 [^]

Fixed issue 40571: OBQuery in ServerStateBackground not using bind params.

Refactored ServerStateBackground query to use bind parameters instead
of appending them to the query string directly.

---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0112968)
AugustoMauch (manager)
2019-06-24 10:58

Code reviewed and verified

- Issue History
Date Modified Username Field Change
2019-04-10 11:25 shuehner New Issue
2019-04-10 11:25 shuehner Assigned To => StoreServer
2019-04-10 11:25 shuehner Triggers an Emergency Pack => No
2019-04-10 11:25 shuehner Relationship added blocks 0038136
2019-05-13 12:45 shuehner Target Version => RR19Q3
2019-05-13 15:02 ranjith_qualiantech_com Assigned To StoreServer => ranjith_qualiantech_com
2019-05-14 11:06 ranjith_qualiantech_com Status new => scheduled
2019-05-15 13:28 marvintm Assigned To ranjith_qualiantech_com => AugustoMauch
2019-05-16 09:05 ranjith_qualiantech_com File Added: issue 40571 source mobilecore.patch
2019-06-21 11:27 jarmendariz Assigned To AugustoMauch => jarmendariz
2019-06-21 13:18 hgbot Checkin
2019-06-21 13:18 hgbot Note Added: 0112939
2019-06-21 13:18 hgbot Status scheduled => resolved
2019-06-21 13:18 hgbot Resolution open => fixed
2019-06-21 13:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/610941ce811b7121724c3283b70352fddaa53eb9 [^]
2019-06-21 13:23 jarmendariz Review Assigned To => AugustoMauch
2019-06-24 10:58 AugustoMauch Note Added: 0112968
2019-06-24 10:58 AugustoMauch Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker