Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040571Retail ModulesStoreServerpublic2019-04-10 11:252019-06-24 10:58
Reportershuehner 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q3Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040571: ServerStateBackground.getServerstoSendPing is not using bind-parameters
DescriptionThis code is not using bind-params:
    OBQuery<MobileServerDefinition> serversQry = OBDal.getInstance()
        .createQuery(MobileServerDefinition.class,
            "client.id=:clientId and " + MobileServerDefinition.PROPERTY_MOBILESERVERKEY + "!='"
                + thisServerDef.getMobileServerKey() + "' and "
                + MobileServerDefinition.PROPERTY_SERVERTYPE + "='" + MobileServerUtils.STORE_SERVER
                + "'" + " order by " + MobileServerDefinition.PROPERTY_PRIORITY);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Filespatch issue 40571 source mobilecore.patch (2,008) 2019-05-16 09:05
https://issues.openbravo.com/file_download.php?file_id=12955&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-10 11:25shuehnerNew Issue
2019-04-10 11:25shuehnerAssigned To => StoreServer
2019-04-10 11:25shuehnerTriggers an Emergency Pack => No
2019-04-10 11:25shuehnerRelationship addedblocks 0038136
2019-05-13 12:45shuehnerTarget Version => RR19Q3
2019-05-13 15:02ranjith_qualiantech_comAssigned ToStoreServer => ranjith_qualiantech_com
2019-05-14 11:06ranjith_qualiantech_comStatusnew => scheduled
2019-05-15 13:28marvintmAssigned Toranjith_qualiantech_com => AugustoMauch
2019-05-16 09:05ranjith_qualiantech_comFile Added: issue 40571 source mobilecore.patch
2019-06-21 11:27jarmendarizAssigned ToAugustoMauch => jarmendariz
2019-06-21 13:18hgbotCheckin
2019-06-21 13:18hgbotNote Added: 0112939
2019-06-21 13:18hgbotStatusscheduled => resolved
2019-06-21 13:18hgbotResolutionopen => fixed
2019-06-21 13:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/610941ce811b7121724c3283b70352fddaa53eb9 [^]
2019-06-21 13:23jarmendarizReview Assigned To => AugustoMauch
2019-06-24 10:58AugustoMauchNote Added: 0112968
2019-06-24 10:58AugustoMauchStatusresolved => closed

Notes
(0112939)
hgbot   
2019-06-21 13:18   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 610941ce811b7121724c3283b70352fddaa53eb9
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 21 11:33:46 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/610941ce811b7121724c3283b70352fddaa53eb9 [^]

Fixed issue 40571: OBQuery in ServerStateBackground not using bind params.

Refactored ServerStateBackground query to use bind parameters instead
of appending them to the query string directly.

---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0112968)
AugustoMauch   
2019-06-24 10:58   
Code reviewed and verified