Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0040544 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] External Data Integration | major | have not tried | 2019-04-05 14:33 | 2019-04-24 17:02 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| Regression introduced in release | ||||||||
| Summary | 0040544: EDL process components are not injected properly | |||||||
| Description | After the Weld upgrade (0040193), EDL process components are not injected properly. This is because the behavior when injecting classes that implement generic interfaces has been redefined. See[1] and [2]. [1] https://docs.jboss.org/cdi/spec/2.0-PFD/cdi-spec.html#assignable_parameters [^] [2] https://issues.jboss.org/browse/WELD-2575 [^] | |||||||
| Steps To Reproduce | 1) Install the https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration.examples [^] 2) Run the [Import UOM] process. Note that it fails. The following error is thrown: org.jboss.weld.exceptions.UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type ItemProcessor<T> with qualifiers @Any @Qualifier at org.jboss.weld.bean.builtin.InstanceImpl.checkBeanResolved(InstanceImpl.java:241) ~[weld-core-impl-3.1.0.Final.jar:3.1.0.Final] at org.jboss.weld.bean.builtin.InstanceImpl.get(InstanceImpl.java:113) ~[weld-core-impl-3.1.0.Final.jar:3.1.0.Final] at org.openbravo.externaldata.integration.process.ProcessRequest.initializeRequest(ProcessRequest.java:183) ~[classes/:?] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0111017) hgbot (developer) 2019-04-08 12:31 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: e75496b57bb148a807fc9ae83fdc378db1c561c9 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Mon Apr 08 12:26:27 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e75496b57bb148a807fc9ae83fdc378db1c561c9 [^] fix issue 40544: EDL process components are not injected properly After the weld upgrade[1] the injection points of ProcessRequest were not being fulfilling the CDI 2.0 assignability rules[2]. Now we use wildcards in the injection points to fulfil the spec rules. [1] https://issues.openbravo.com/view.php?id=40193 [^] [2] http://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#assignable_parameters [^] --- M src/org/openbravo/externaldata/integration/process/ProcessRequest.java --- |
|
(0111021) hgbot (developer) 2019-04-08 12:52 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: c0c632bb4cacea857115ae0400bc69bfdd56676e Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Mon Apr 08 12:49:35 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/c0c632bb4cacea857115ae0400bc69bfdd56676e [^] related to issue 40544: minor code cleanup - Remove redundant "static" qualifier in enum - Remove commented-out lines - Immediately return expression instead of assigning it to the temporary variable "processRequest" - Use diamond operator - Use the returned value of "concat" - Renamed parameter - Removed nested if - Define a constant instead of duplicating this literal "processid" 3 times --- M src/org/openbravo/externaldata/integration/process/ProcessRequest.java --- |
|
(0111289) AugustoMauch (manager) 2019-04-24 17:02 |
Code reviewed and verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-04-05 14:33 | caristu | New Issue | |
| 2019-04-05 14:33 | caristu | Assigned To | => caristu |
| 2019-04-05 14:33 | caristu | Relationship added | caused by 0040193 |
| 2019-04-05 14:34 | caristu | Steps to Reproduce Updated | View Revisions |
| 2019-04-05 14:35 | caristu | Description Updated | View Revisions |
| 2019-04-08 12:31 | hgbot | Checkin | |
| 2019-04-08 12:31 | hgbot | Note Added: 0111017 | |
| 2019-04-08 12:32 | caristu | Status | new => acknowledged |
| 2019-04-08 12:32 | caristu | Status | acknowledged => scheduled |
| 2019-04-08 12:32 | caristu | Status | scheduled => resolved |
| 2019-04-08 12:32 | caristu | Resolution | open => fixed |
| 2019-04-08 12:32 | caristu | Review Assigned To | => AugustoMauch |
| 2019-04-08 12:52 | hgbot | Checkin | |
| 2019-04-08 12:52 | hgbot | Note Added: 0111021 | |
| 2019-04-24 17:02 | AugustoMauch | Note Added: 0111289 | |
| 2019-04-24 17:02 | AugustoMauch | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |