Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040544ModulesExternal Data Integrationpublic2019-04-05 14:332019-04-24 17:02
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToAugustoMauch
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0040544: EDL process components are not injected properly
DescriptionAfter the Weld upgrade (0040193), EDL process components are not injected properly.

This is because the behavior when injecting classes that implement generic interfaces has been redefined. See[1] and [2].

[1] https://docs.jboss.org/cdi/spec/2.0-PFD/cdi-spec.html#assignable_parameters [^]
[2] https://issues.jboss.org/browse/WELD-2575 [^]
Steps To Reproduce1) Install the https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration.examples [^]

2) Run the [Import UOM] process. Note that it fails. The following error is thrown:

org.jboss.weld.exceptions.UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type ItemProcessor<T> with qualifiers @Any @Qualifier
    at org.jboss.weld.bean.builtin.InstanceImpl.checkBeanResolved(InstanceImpl.java:241) ~[weld-core-impl-3.1.0.Final.jar:3.1.0.Final]
    at org.jboss.weld.bean.builtin.InstanceImpl.get(InstanceImpl.java:113) ~[weld-core-impl-3.1.0.Final.jar:3.1.0.Final]
    at org.openbravo.externaldata.integration.process.ProcessRequest.initializeRequest(ProcessRequest.java:183) ~[classes/:?]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0040193 closed caristu Openbravo ERP upgrade Weld to version 3.1.0.Final 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-05 14:33caristuNew Issue
2019-04-05 14:33caristuAssigned To => caristu
2019-04-05 14:33caristuOBNetwork customer => No
2019-04-05 14:33caristuRelationship addedcaused by 0040193
2019-04-05 14:34caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18600#r18600
2019-04-05 14:35caristuDescription Updatedbug_revision_view_page.php?rev_id=18602#r18602
2019-04-08 12:31hgbotCheckin
2019-04-08 12:31hgbotNote Added: 0111017
2019-04-08 12:32caristuStatusnew => acknowledged
2019-04-08 12:32caristuStatusacknowledged => scheduled
2019-04-08 12:32caristuStatusscheduled => resolved
2019-04-08 12:32caristuResolutionopen => fixed
2019-04-08 12:32caristuReview Assigned To => AugustoMauch
2019-04-08 12:52hgbotCheckin
2019-04-08 12:52hgbotNote Added: 0111021
2019-04-24 17:02AugustoMauchNote Added: 0111289
2019-04-24 17:02AugustoMauchStatusresolved => closed

Notes
(0111017)
hgbot   
2019-04-08 12:31   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: e75496b57bb148a807fc9ae83fdc378db1c561c9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Apr 08 12:26:27 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e75496b57bb148a807fc9ae83fdc378db1c561c9 [^]

fix issue 40544: EDL process components are not injected properly

  After the weld upgrade[1] the injection points of ProcessRequest were not being fulfilling the CDI 2.0 assignability rules[2]. Now we use wildcards in the injection points to fulfil the spec rules.

  [1] https://issues.openbravo.com/view.php?id=40193 [^]
  [2] http://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#assignable_parameters [^]

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0111021)
hgbot   
2019-04-08 12:52   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: c0c632bb4cacea857115ae0400bc69bfdd56676e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Apr 08 12:49:35 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/c0c632bb4cacea857115ae0400bc69bfdd56676e [^]

related to issue 40544: minor code cleanup

  - Remove redundant "static" qualifier in enum
  - Remove commented-out lines
  - Immediately return expression instead of assigning it to the temporary variable "processRequest"
  - Use diamond operator
  - Use the returned value of "concat"
  - Renamed parameter
  - Removed nested if
  - Define a constant instead of duplicating this literal "processid" 3 times

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0111289)
AugustoMauch   
2019-04-24 17:02   
Code reviewed and verified