0040473: An order can be paid with Credit Note for a customer without credit/balance available

# HG changeset patch
# User Rafael Queralta <rafaelcuba81@gmail.com>
# Date 1554321165 14400
#      Wed Apr 03 15:52:45 2019 -0400
# Node ID 8213e037bbafcd831f7e4a9fe122450d59be6fc8
# Parent  6d31242e7525684eea08173b9ff0a05c9540167b
Fixed issue 40473: An order can be paid with Credit Note for a customer without
credit/balance available

- Fixed Pay Open Ticket flow to avoid pay ticket with negative payments into
normal receipts. Not only the payments added in multiOrders view are checked,
the payments related with the receipts are checked now to find negatives payments.
This kind of payments are not allowed in normal receipts

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
@@ -1642,11 +1642,27 @@
 
           var errorMsgLbl, totalPaid = 0,
               totalToPaid = OB.DEC.abs(isMultiOrder ? me.owner.model.get('multiOrders').getTotal() : me.owner.receipt.getTotal()),
-              isReturnOrder = isMultiOrder ? false : me.owner.receipt.isNegative();
+              isReturnOrder = isMultiOrder ? false : me.owner.receipt.isNegative(),
+              paymentsMultiOrders, paymentsOrder;
+
 
-          if (_.filter(payments.models, function (payment) {
+          if (isMultiOrder) {
+            var receipts = me.owner.model.get('multiOrders').get('multiOrdersList').models;
+            receipts.forEach(function (receipt) {
+              paymentsMultiOrders = _.filter(receipt.get('payments').models, function (payment) {
+                return (OB.UTIL.isNullOrUndefined(payment.get('isReturnOrder')) ? isReturnOrder : payment.get('isReturnOrder')) !== isReturnOrder;
+              });
+              if (paymentsMultiOrders.length > 0) {
+                return;
+              }
+            });
+          }
+
+          paymentsOrder = _.filter(payments.models, function (payment) {
             return (OB.UTIL.isNullOrUndefined(payment.get('isReturnOrder')) ? isReturnOrder : payment.get('isReturnOrder')) !== isReturnOrder;
-          }).length > 0) {
+          });
+
+          if (paymentsOrder.length > 0 || (isMultiOrder && paymentsMultiOrders.length > 0)) {
             me.avoidCompleteReceipt = true;
             if (isReturnOrder) {
               errorMsgLbl = 'OBPOS_PaymentOnReturnReceipt';