Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040473Retail ModulesWeb POSpublic2019-03-28 10:472019-04-24 13:49
Reporterucarrion 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040473: An order can be paid with Credit Note for a customer without credit/balance available
DescriptionAn order can be paid with a credit note for a customer with no balance available if the credit note is added to the order as a return by using ‘Pay Open Tickets’ menu option.
Steps To Reproduce+Create an order adding a product
+Click the orderline and press ‘Return Line’
+Add a payment in ‘Credit Note’ (both total and partial are OK to test)
+Click again the orderline and press ‘Return Line’
+Tap the total amount button again and complete the order payment
+Once order processed, go to backend and check that
+Sales order has been paid partially/totally by credit note for a customer with no balance available
+Gift card instance window, check that the credit note has been generated and the amount is available


VIDEO --> https://drive.google.com/file/d/1-pKlAL8C3WkkbWE5LCS5FQVl91PDjMHQ/view [^]
Proposed SolutionWhen trying to go back to a ‘positive’ line, Webpos should check that the customer has available balance or not.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 40473.diff (2,488) 2019-04-04 13:02
https://issues.openbravo.com/file_download.php?file_id=12837&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-28 10:47ucarrionNew Issue
2019-03-28 10:47ucarrionAssigned To => Retail
2019-03-28 10:47ucarrionOBNetwork customer => Gold
2019-03-28 10:47ucarrionResolution time => 1552258800
2019-03-28 10:47ucarrionTriggers an Emergency Pack => No
2019-03-28 15:13jorge-garciaResolution time1552258800 => 1554933600
2019-04-01 03:34rqueraltaAssigned ToRetail => rqueralta
2019-04-01 03:34rqueraltaStatusnew => scheduled
2019-04-04 13:02rqueraltaFile Added: 40473.diff
2019-04-05 14:40hgbotCheckin
2019-04-05 14:40hgbotNote Added: 0111003
2019-04-05 14:40hgbotStatusscheduled => resolved
2019-04-05 14:40hgbotResolutionopen => fixed
2019-04-05 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6cca9a779aa93ad70213ed275d4fa8e6c28df0a [^]
2019-04-09 15:31hgbotCheckin
2019-04-09 15:31hgbotNote Added: 0111046
2019-04-24 13:49adrianromeroReview Assigned To => adrianromero
2019-04-24 13:49adrianromeroNote Added: 0111279
2019-04-24 13:49adrianromeroStatusresolved => closed
2019-04-24 13:49adrianromeroFixed in Version => RR19Q3

Notes
(0111003)
hgbot   
2019-04-05 14:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6cca9a779aa93ad70213ed275d4fa8e6c28df0a
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Apr 03 15:52:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6cca9a779aa93ad70213ed275d4fa8e6c28df0a [^]

Fixed issue 40473: An order can be paid with Credit Note for a customer without
credit/balance available

- Fixed Pay Open Ticket flow to avoid pay ticket with negative payments into
normal receipts. Not only the payments added in multiOrders view are checked,
the payments related with the receipts are checked now to find negatives payments.
This kind of payments are not allowed in normal receipts

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0111046)
hgbot   
2019-04-09 15:31   
Repository: tools/automation/pi-mobile
Changeset: 13f9ab79481e1da30cf2c2c407addca0bdeb9089
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Apr 05 10:21:13 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/13f9ab79481e1da30cf2c2c407addca0bdeb9089 [^]

Related to issue 40473: added automated test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/I40473_VerifyCreditNoteForCustomerWithoutCredit.java
---
(0111279)
adrianromero   
2019-04-24 13:49   
Verified.