Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040328
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Copy Retail Storemajoralways2019-03-06 11:032019-03-07 09:40
ReporterAsantos9View Statuspublic 
Assigned ToRetail 
PriorityhighResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression levelPackaging and release
Regression date2018-08-03
Regression introduced in releaseRR18Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/a3bc37e5e273 [^]
Triggers an Emergency PackNo
Summary

0040328: Error while executing the copy store process using a XLS file in 19Q1

DescriptionA null pointer exception is thrown when a copy store process is executed using a file.

It happens because the commit which causes the regression added a condition which tries to read the value of the property name of an object (originalTerminal) which is null when copy process is executed from file.

To fix this problem object should be initialized also in the flow executed when copy store is used from file.

Steps To Reproduce1. Log into Openbravo ERP
2. Go to Copy Retail Store
3. Fill mandatory fields
4. Check Use File flag and upload an excel file

Note that the following exception is thrown:

2019-03-05 15:50:39,672 [ajp-nio-127.0.0.1-8009-exec-3] ERROR org.openbravo.retail.copystore.process.CopyStoreProcess - Error in process
java.lang.NullPointerException: null
        at org.openbravo.retail.copystore.process.CopyStoreProcess.copyTerminalTypes(CopyStoreProcess.java:1436) ~[classes/:?]
        at org.openbravo.retail.copystore.process.POSTerminalsProcess$TerminalTypeColumn.processColumn(POSTerminalsProcess.java:160) ~[classes/:?]
        at org.openbravo.retail.copystore.process.POSTerminalsProcess$TerminalTypeColumn.processColumn(POSTerminalsProcess.java:155) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TerminalTypeColumn$Proxy$_$$_WeldClientProxy.processColumn(TerminalTypeColumn$Proxy$_$$_WeldClientProxy.java) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processField(TabHandler.java:394) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processRecord(TabHandler.java:284) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.executeRecord(TabHandler.java:220) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processSection(TabHandler.java:92) ~[classes/:?]
        at org.openbravo.retail.copystore.process.CopyStoreProcess.processSection(CopyStoreProcess.java:814) ~[classes/:?]
        at org.openbravo.retail.copystore.process.CopyStoreProcess.copyFromFile(CopyStoreProcess.java:789) [classes/:?]
Proposed SolutionTo fix this problem object should be initialized also in the flow executed when copy store is used from file.
TagsNo tags attached.
Attached Filesdiff file icon fixCopyStoreRegression.diff [^] (840 bytes) 2019-03-06 11:03 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0039091 closedrqueralta 'Copy Retail Store' copied names for some windows can be problematic 

-  Notes
(0110265)
hgbot (developer)
2019-03-06 16:44

 Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 550dfbaea315a79e9afefbd3a31a11967bd4c0ec
Author: Alberto Santos <albertosantos9 <at> hotmail.com>
Date: Wed Mar 06 16:43:20 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/550dfbaea315a79e9afefbd3a31a11967bd4c0ec [^]

Related to issue 40328: Copy Store Process is not working using files

---
M src/org/openbravo/retail/copystore/process/POSTerminalsProcess.java
---
(0110267)
guilleaer (manager)
2019-03-06 17:14

 To take advantage of this fix in 19Q1 this patch should be applied in that version of copy store module

- Issue History
Date Modified Username Field Change
2019-03-06 11:03 Asantos9 New Issue
2019-03-06 11:03 Asantos9 Assigned To => Retail
2019-03-06 11:03 Asantos9 File Added: fixCopyStoreRegression.diff
2019-03-06 11:03 Asantos9 Resolution time => 1553641200
2019-03-06 11:03 Asantos9 Regression level => Packaging and release
2019-03-06 11:03 Asantos9 Regression date => 2018-10-05
2019-03-06 11:03 Asantos9 Regression introduced in release => main
2019-03-06 11:03 Asantos9 Triggers an Emergency Pack => No
2019-03-06 11:08 Asantos9 Steps to Reproduce Updated View Revisions
2019-03-06 16:44 hgbot Checkin
2019-03-06 16:44 hgbot Note Added: 0110265
2019-03-06 16:45 guilleaer Status new => scheduled
2019-03-06 16:45 guilleaer Status scheduled => resolved
2019-03-06 16:45 guilleaer Fixed in Version => RR19Q2
2019-03-06 16:45 guilleaer Resolution open => fixed
2019-03-06 17:14 guilleaer Review Assigned To => guilleaer
2019-03-06 17:14 guilleaer Note Added: 0110267
2019-03-06 17:14 guilleaer Status resolved => closed
2019-03-06 23:19 guilleaer Regression introduced in release main =>
2019-03-06 23:19 guilleaer Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/09e0a4b66d8c [^]
2019-03-06 23:19 guilleaer Summary Error while executing the copy store process using a file => Error while executing the copy store process using a XLS file in 19Q1
2019-03-07 09:21 guilleaer Regression date 2018-10-05 => 2018-08-03
2019-03-07 09:21 guilleaer Regression introduced by commit https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/09e0a4b66d8c [^] => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/a3bc37e5e273 [^]
2019-03-07 09:25 guilleaer Regression introduced in release => RR18Q4
2019-03-07 09:25 guilleaer Description Updated View Revisions
2019-03-07 09:25 guilleaer Proposed Solution updated
2019-03-07 09:40 dmitry_mezentsev Relationship added caused by 0039091

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker