Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040328Retail ModulesCopy Retail Storepublic2019-03-06 11:032019-03-07 09:40
ReporterAsantos9 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date2018-08-03
Regression introduced in releaseRR18Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/a3bc37e5e273 [^]
Triggers an Emergency PackNo
Summary0040328: Error while executing the copy store process using a XLS file in 19Q1
DescriptionA null pointer exception is thrown when a copy store process is executed using a file.

It happens because the commit which causes the regression added a condition which tries to read the value of the property name of an object (originalTerminal) which is null when copy process is executed from file.

To fix this problem object should be initialized also in the flow executed when copy store is used from file.

Steps To Reproduce1. Log into Openbravo ERP
2. Go to Copy Retail Store
3. Fill mandatory fields
4. Check Use File flag and upload an excel file

Note that the following exception is thrown:

2019-03-05 15:50:39,672 [ajp-nio-127.0.0.1-8009-exec-3] ERROR org.openbravo.retail.copystore.process.CopyStoreProcess - Error in process
java.lang.NullPointerException: null
        at org.openbravo.retail.copystore.process.CopyStoreProcess.copyTerminalTypes(CopyStoreProcess.java:1436) ~[classes/:?]
        at org.openbravo.retail.copystore.process.POSTerminalsProcess$TerminalTypeColumn.processColumn(POSTerminalsProcess.java:160) ~[classes/:?]
        at org.openbravo.retail.copystore.process.POSTerminalsProcess$TerminalTypeColumn.processColumn(POSTerminalsProcess.java:155) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TerminalTypeColumn$Proxy$_$$_WeldClientProxy.processColumn(TerminalTypeColumn$Proxy$_$$_WeldClientProxy.java) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processField(TabHandler.java:394) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processRecord(TabHandler.java:284) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.executeRecord(TabHandler.java:220) ~[classes/:?]
        at org.openbravo.retail.copystore.process.TabHandler.processSection(TabHandler.java:92) ~[classes/:?]
        at org.openbravo.retail.copystore.process.CopyStoreProcess.processSection(CopyStoreProcess.java:814) ~[classes/:?]
        at org.openbravo.retail.copystore.process.CopyStoreProcess.copyFromFile(CopyStoreProcess.java:789) [classes/:?]
Proposed SolutionTo fix this problem object should be initialized also in the flow executed when copy store is used from file.
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0039091 closed rqueralta 'Copy Retail Store' copied names for some windows can be problematic 
Attached Filesdiff fixCopyStoreRegression.diff (840) 2019-03-06 11:03
https://issues.openbravo.com/file_download.php?file_id=12714&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-03-06 11:03Asantos9New Issue
2019-03-06 11:03Asantos9Assigned To => Retail
2019-03-06 11:03Asantos9File Added: fixCopyStoreRegression.diff
2019-03-06 11:03Asantos9Resolution time => 1553641200
2019-03-06 11:03Asantos9Regression level => Packaging and release
2019-03-06 11:03Asantos9Regression date => 2018-10-05
2019-03-06 11:03Asantos9Regression introduced in release => main
2019-03-06 11:03Asantos9Triggers an Emergency Pack => No
2019-03-06 11:08Asantos9Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=18394#r18394
2019-03-06 16:44hgbotCheckin
2019-03-06 16:44hgbotNote Added: 0110265
2019-03-06 16:45guilleaerStatusnew => scheduled
2019-03-06 16:45guilleaerStatusscheduled => resolved
2019-03-06 16:45guilleaerFixed in Version => RR19Q2
2019-03-06 16:45guilleaerResolutionopen => fixed
2019-03-06 17:14guilleaerReview Assigned To => guilleaer
2019-03-06 17:14guilleaerNote Added: 0110267
2019-03-06 17:14guilleaerStatusresolved => closed
2019-03-06 23:19guilleaerRegression introduced in releasemain =>
2019-03-06 23:19guilleaerRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/09e0a4b66d8c [^]
2019-03-06 23:19guilleaerSummaryError while executing the copy store process using a file => Error while executing the copy store process using a XLS file in 19Q1
2019-03-07 09:21guilleaerRegression date2018-10-05 => 2018-08-03
2019-03-07 09:21guilleaerRegression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/09e0a4b66d8c [^] => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/a3bc37e5e273 [^]
2019-03-07 09:25guilleaerRegression introduced in release => RR18Q4
2019-03-07 09:25guilleaerDescription Updatedbug_revision_view_page.php?rev_id=18398#r18398
2019-03-07 09:25guilleaerProposed Solution updated
2019-03-07 09:40dmitry_mezentsevRelationship addedcaused by 0039091

Notes
(0110265)
hgbot   
2019-03-06 16:44   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 550dfbaea315a79e9afefbd3a31a11967bd4c0ec
Author: Alberto Santos <albertosantos9 <at> hotmail.com>
Date: Wed Mar 06 16:43:20 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/550dfbaea315a79e9afefbd3a31a11967bd4c0ec [^]

Related to issue 40328: Copy Store Process is not working using files

---
M src/org/openbravo/retail/copystore/process/POSTerminalsProcess.java
---
(0110267)
guilleaer   
2019-03-06 17:14   
To take advantage of this fix in 19Q1 this patch should be applied in that version of copy store module