Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040279
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POS Hardware Managermajoralways2019-02-27 10:092019-03-12 17:20
ReportermalsasuaView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision3e5339aa04e5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket7859
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040279: The size of integer variable is not enough for Serial Number

DescriptionIn the RFID process, the serial number is stored in a variable of type Integer.

In some cases, the Serial Number is high, and Integer is not enough.

It should be changed to BigInteger

Steps To Reproducen/a
Proposed Solutionattached a diff with the solution
TagsNo tags attached.
Attached Filesdiff file icon diffToBigInteger.diff [^] (964 bytes) 2019-02-27 10:27 [Show Content]
diff file icon last_diffToBigInteger.diff [^] (1,277 bytes) 2019-03-08 14:14 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0110330)
hgbot (developer)
2019-03-09 17:56

 Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 801d52515e173ffaa0c3823ac9ab2e70b6ace14c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 05 13:32:35 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial Number changed to BigInteger type

---
M bin/poshw.jar
M bin/rev.id
---
(0110335)
jorge-garcia (viewer)
2019-03-11 08:56

 Missing changes in https://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources [^] module
(0110350)
hgbot (developer)
2019-03-11 13:59

 Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: e172bd742844bd798283cadb7b6561d30349e325
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 07:18:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial number type was changed to BigInteger

---
M project/src/com/openbravo/pos/util/RFIDEncoding.java
---
(0110351)
hgbot (developer)
2019-03-11 14:00

 Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 47d786aa3fb6b7b536dd5cf729a73321f3516f87
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 08:47:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/47d786aa3fb6b7b536dd5cf729a73321f3516f87 [^]

Related issue 40279:The size of integer variable is not enough for Serial Number

- Backed out changeset: 801d52515e17

---
M bin/poshw.jar
M bin/rev.id
---
(0110352)
hgbot (developer)
2019-03-11 14:00

 Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 507deaffdd21c14349b98eead68b9587306a98fb
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 08:48:49 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial Number changed to BigInteger type

---
M bin/poshw.jar
M bin/rev.id
---
(0110368)
jorge-garcia (viewer)
2019-03-12 08:43

 Missing security check

+ // if binary serial number length is higher than 38 chars, it is one error, and it generates one
+ // exception in HW Manager. To prevent it, we will cut the first digits
+ if (binarySerialNumberString.length()>38) {
+ binarySerialNumberString = binarySerialNumberString.substring(0, 38);
+ }
(0110385)
hgbot (developer)
2019-03-12 14:59

 Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: a595c39810d80dbaca7bd359f3dbdbe014bc9e22
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 12 09:57:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Added Missing security check

---
M project/src/com/openbravo/pos/util/RFIDEncoding.java
---
(0110386)
hgbot (developer)
2019-03-12 14:59

 Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 3e5339aa04e527624ace880f72ab31e6682ff2a8
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 12 09:57:30 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/3e5339aa04e527624ace880f72ab31e6682ff2a8 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Added Missing security check

---
M bin/poshw.jar
M bin/rev.id
---
(0110389)
jorge-garcia (viewer)
2019-03-12 17:20

 Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-02-27 10:09 malsasua New Issue
2019-02-27 10:09 malsasua Assigned To => Retail
2019-02-27 10:09 malsasua File Added: diffToBigInteger.diff
2019-02-27 10:09 malsasua OBNetwork customer => Gold
2019-02-27 10:09 malsasua Support ticket => 7859
2019-02-27 10:09 malsasua Resolution time => 1552777200
2019-02-27 10:09 malsasua Triggers an Emergency Pack => No
2019-02-27 10:27 malsasua File Deleted: diffToBigInteger.diff
2019-02-27 10:27 malsasua File Added: diffToBigInteger.diff
2019-03-05 15:44 rqueralta Assigned To Retail => rqueralta
2019-03-05 19:29 rqueralta Status new => scheduled
2019-03-08 14:14 malsasua File Added: last_diffToBigInteger.diff
2019-03-09 17:56 hgbot Checkin
2019-03-09 17:56 hgbot Note Added: 0110330
2019-03-09 17:56 hgbot Status scheduled => resolved
2019-03-09 17:56 hgbot Resolution open => fixed
2019-03-09 17:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^]
2019-03-11 08:56 jorge-garcia Note Added: 0110335
2019-03-11 08:56 jorge-garcia Status resolved => new
2019-03-11 08:56 jorge-garcia Resolution fixed => open
2019-03-11 08:58 jorge-garcia Review Assigned To => jorge-garcia
2019-03-11 13:59 hgbot Checkin
2019-03-11 13:59 hgbot Note Added: 0110350
2019-03-11 13:59 hgbot Status new => resolved
2019-03-11 13:59 hgbot Resolution open => fixed
2019-03-11 13:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^]
2019-03-11 14:00 hgbot Checkin
2019-03-11 14:00 hgbot Note Added: 0110351
2019-03-11 14:00 hgbot Checkin
2019-03-11 14:00 hgbot Note Added: 0110352
2019-03-11 14:00 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^]
2019-03-12 08:44 jorge-garcia Note Added: 0110368
2019-03-12 08:44 jorge-garcia Status resolved => new
2019-03-12 08:44 jorge-garcia Resolution fixed => open
2019-03-12 09:41 jorge-garcia Assigned To rqueralta => jorge-garcia
2019-03-12 09:41 jorge-garcia Status new => scheduled
2019-03-12 13:27 jorge-garcia Assigned To jorge-garcia => rqueralta
2019-03-12 14:59 hgbot Checkin
2019-03-12 14:59 hgbot Note Added: 0110385
2019-03-12 14:59 hgbot Status scheduled => resolved
2019-03-12 14:59 hgbot Resolution open => fixed
2019-03-12 14:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^]
2019-03-12 14:59 hgbot Checkin
2019-03-12 14:59 hgbot Note Added: 0110386
2019-03-12 14:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/3e5339aa04e527624ace880f72ab31e6682ff2a8 [^]
2019-03-12 17:20 jorge-garcia Note Added: 0110389
2019-03-12 17:20 jorge-garcia Status resolved => closed
2019-03-12 17:20 jorge-garcia Fixed in Version => RR19Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker