Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040279Retail ModulesWeb POS Hardware Managerpublic2019-02-27 10:092019-03-12 17:20
Reportermalsasua 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket7859
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040279: The size of integer variable is not enough for Serial Number
DescriptionIn the RFID process, the serial number is stored in a variable of type Integer.

In some cases, the Serial Number is high, and Integer is not enough.

It should be changed to BigInteger

Steps To Reproducen/a
Proposed Solutionattached a diff with the solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff diffToBigInteger.diff (964) 2019-02-27 10:27
https://issues.openbravo.com/file_download.php?file_id=12688&type=bug
diff last_diffToBigInteger.diff (1,277) 2019-03-08 14:14
https://issues.openbravo.com/file_download.php?file_id=12729&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-27 10:09malsasuaNew Issue
2019-02-27 10:09malsasuaAssigned To => Retail
2019-02-27 10:09malsasuaFile Added: diffToBigInteger.diff
2019-02-27 10:09malsasuaOBNetwork customer => Gold
2019-02-27 10:09malsasuaSupport ticket => 7859
2019-02-27 10:09malsasuaResolution time => 1552777200
2019-02-27 10:09malsasuaTriggers an Emergency Pack => No
2019-02-27 10:27malsasuaFile Deleted: diffToBigInteger.diff
2019-02-27 10:27malsasuaFile Added: diffToBigInteger.diff
2019-03-05 15:44rqueraltaAssigned ToRetail => rqueralta
2019-03-05 19:29rqueraltaStatusnew => scheduled
2019-03-08 14:14malsasuaFile Added: last_diffToBigInteger.diff
2019-03-09 17:56hgbotCheckin
2019-03-09 17:56hgbotNote Added: 0110330
2019-03-09 17:56hgbotStatusscheduled => resolved
2019-03-09 17:56hgbotResolutionopen => fixed
2019-03-09 17:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^]
2019-03-11 08:56jorge-garciaNote Added: 0110335
2019-03-11 08:56jorge-garciaStatusresolved => new
2019-03-11 08:56jorge-garciaResolutionfixed => open
2019-03-11 08:58jorge-garciaReview Assigned To => jorge-garcia
2019-03-11 13:59hgbotCheckin
2019-03-11 13:59hgbotNote Added: 0110350
2019-03-11 13:59hgbotStatusnew => resolved
2019-03-11 13:59hgbotResolutionopen => fixed
2019-03-11 13:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^]
2019-03-11 14:00hgbotCheckin
2019-03-11 14:00hgbotNote Added: 0110351
2019-03-11 14:00hgbotCheckin
2019-03-11 14:00hgbotNote Added: 0110352
2019-03-11 14:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^]
2019-03-12 08:44jorge-garciaNote Added: 0110368
2019-03-12 08:44jorge-garciaStatusresolved => new
2019-03-12 08:44jorge-garciaResolutionfixed => open
2019-03-12 09:41jorge-garciaAssigned Torqueralta => jorge-garcia
2019-03-12 09:41jorge-garciaStatusnew => scheduled
2019-03-12 13:27jorge-garciaAssigned Tojorge-garcia => rqueralta
2019-03-12 14:59hgbotCheckin
2019-03-12 14:59hgbotNote Added: 0110385
2019-03-12 14:59hgbotStatusscheduled => resolved
2019-03-12 14:59hgbotResolutionopen => fixed
2019-03-12 14:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^]
2019-03-12 14:59hgbotCheckin
2019-03-12 14:59hgbotNote Added: 0110386
2019-03-12 14:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/3e5339aa04e527624ace880f72ab31e6682ff2a8 [^]
2019-03-12 17:20jorge-garciaNote Added: 0110389
2019-03-12 17:20jorge-garciaStatusresolved => closed
2019-03-12 17:20jorge-garciaFixed in Version => RR19Q2

Notes
(0110330)
hgbot   
2019-03-09 17:56   
Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 801d52515e173ffaa0c3823ac9ab2e70b6ace14c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 05 13:32:35 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/801d52515e173ffaa0c3823ac9ab2e70b6ace14c [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial Number changed to BigInteger type

---
M bin/poshw.jar
M bin/rev.id
---
(0110335)
jorge-garcia   
2019-03-11 08:56   
Missing changes in https://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources [^] module
(0110350)
hgbot   
2019-03-11 13:59   
Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: e172bd742844bd798283cadb7b6561d30349e325
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 07:18:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/e172bd742844bd798283cadb7b6561d30349e325 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial number type was changed to BigInteger

---
M project/src/com/openbravo/pos/util/RFIDEncoding.java
---
(0110351)
hgbot   
2019-03-11 14:00   
Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 47d786aa3fb6b7b536dd5cf729a73321f3516f87
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 08:47:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/47d786aa3fb6b7b536dd5cf729a73321f3516f87 [^]

Related issue 40279:The size of integer variable is not enough for Serial Number

- Backed out changeset: 801d52515e17

---
M bin/poshw.jar
M bin/rev.id
---
(0110352)
hgbot   
2019-03-11 14:00   
Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 507deaffdd21c14349b98eead68b9587306a98fb
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 08:48:49 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/507deaffdd21c14349b98eead68b9587306a98fb [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Serial Number changed to BigInteger type

---
M bin/poshw.jar
M bin/rev.id
---
(0110368)
jorge-garcia   
2019-03-12 08:43   
Missing security check

+ // if binary serial number length is higher than 38 chars, it is one error, and it generates one
+ // exception in HW Manager. To prevent it, we will cut the first digits
+ if (binarySerialNumberString.length()>38) {
+ binarySerialNumberString = binarySerialNumberString.substring(0, 38);
+ }
(0110385)
hgbot   
2019-03-12 14:59   
Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: a595c39810d80dbaca7bd359f3dbdbe014bc9e22
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 12 09:57:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/a595c39810d80dbaca7bd359f3dbdbe014bc9e22 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Added Missing security check

---
M project/src/com/openbravo/pos/util/RFIDEncoding.java
---
(0110386)
hgbot   
2019-03-12 14:59   
Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 3e5339aa04e527624ace880f72ab31e6682ff2a8
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 12 09:57:30 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/3e5339aa04e527624ace880f72ab31e6682ff2a8 [^]

Fixed issue 40279: The size of integer variable is not enough for Serial Number

- Added Missing security check

---
M bin/poshw.jar
M bin/rev.id
---
(0110389)
jorge-garcia   
2019-03-12 17:20   
Code reviewed and tested