Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040232
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-02-18 13:392019-04-26 11:40
Reportersamuel_nicuesaView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revisionb677ab98d084
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040232: Sales quotation is not saved in Back Office

DescriptionAfter completing a quotation if the cashier press X button before Sync message is displayed, the quotation won't be saved in Back Office.
Steps To Reproduce[POS]

-Configure Chrome performance 6x slowdown
-Create quotation
-Add one product
-Press Amount button and the Quotation will be closed
-Before sync quotation message is shown on top right corner you will need to press X button.

[BO]

-Check that quotation has not been saved.
TagsNo tags attached.
Attached Filespatch file icon 40232_FinalPatch.patch [^] (5,972 bytes) 2019-03-28 13:33 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0040689 newRetail Wrong order status if calculate currentcash or updateDocumentSequenceWhenOrderSaved fails in syncrhonize mode 

-  Notes
(0110282)
hgbot (developer)
2019-03-07 14:36

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 88a5c9b52b17a8178dcb80b29903828dc5f4c048
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 04 18:42:19 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Button 'Delete' is disabled until the processing of the order ends

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0110324)
jorge-garcia (reporter)
2019-03-08 14:28

The solution is not complete. If some creates a quotation and a 'OBPOS_PreOrderSave' registered hook launches a cancellation, the process and the scrim will remain in process forever.

Don't start a process depending on document type, the process tapTotalButton makes sense for other type of documents.
(0110463)
hgbot (developer)
2019-03-15 23:12

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 17:11:08 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Start "tapTotalButton" process for any document type

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0110499)
hgbot (developer)
2019-03-19 19:42

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f4c894011bbbc690e28c58116934d6ed2b9db3b0
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 18 09:45:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4c894011bbbc690e28c58116934d6ed2b9db3b0 [^]

Related to issue 40232: Sales quotation is not saved in Back Office

- Adde new function to finish a process controller running by searchkey

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0110512)
jorge-garcia (reporter)
2019-03-20 13:57

Processes execution should be a scoped variable in the same context.

OB.UTIL.finishProcessesRunningBySearchKey function is not correct and should not exists (and I don't know why it's needed). In case a process should finish outside the definition scope, two scoped processes should be created instead of using the same.
(0110704)
hgbot (developer)
2019-03-27 16:12

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e177d56da527e1cfd50a3866a9d684ef8194067b
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Mar 27 12:31:17 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e177d56da527e1cfd50a3866a9d684ef8194067b [^]

Related to issue 40348. Backout of issue 40232. ProcessController.getProcessesRunning no longer exists

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0111001)
hgbot (developer)
2019-04-05 14:38

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Mar 27 12:05:41 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Button 'Delete' is disabled until the processing of the order ends. A new
process controller registered to this button was added to do it.

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0111022)
jorge-garcia (reporter)
2019-04-08 13:36

Missing end of tapTotalButton process in two places (at least)

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l289 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l381 [^]
(0111068)
hgbot (developer)
2019-04-10 23:41

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b677ab98d08415836ce3c865772471e08b523edd
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 08 13:48:23 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b677ab98d08415836ce3c865772471e08b523edd [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Added missing end of tapTotalButton process in two places.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0111358)
jorge-garcia (reporter)
2019-04-26 11:29

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-02-18 13:39 samuel_nicuesa New Issue
2019-02-18 13:39 samuel_nicuesa Assigned To => Retail
2019-02-18 13:39 samuel_nicuesa Resolution time => 1552258800
2019-02-18 13:39 samuel_nicuesa Triggers an Emergency Pack => No
2019-02-18 13:41 rafaroda Issue Monitored: rafaroda
2019-02-18 20:13 rqueralta Assigned To Retail => rqueralta
2019-02-18 20:13 rqueralta Status new => scheduled
2019-03-07 14:36 hgbot Checkin
2019-03-07 14:36 hgbot Note Added: 0110282
2019-03-07 14:36 hgbot Status scheduled => resolved
2019-03-07 14:36 hgbot Resolution open => fixed
2019-03-07 14:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^]
2019-03-08 14:07 jorge-garcia Review Assigned To => jorge-garcia
2019-03-08 14:28 jorge-garcia Note Added: 0110324
2019-03-08 14:28 jorge-garcia Status resolved => new
2019-03-08 14:28 jorge-garcia Resolution fixed => open
2019-03-15 23:12 hgbot Checkin
2019-03-15 23:12 hgbot Note Added: 0110463
2019-03-15 23:12 hgbot Status new => resolved
2019-03-15 23:12 hgbot Resolution open => fixed
2019-03-15 23:12 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^]
2019-03-19 19:42 hgbot Checkin
2019-03-19 19:42 hgbot Note Added: 0110499
2019-03-20 13:57 jorge-garcia Note Added: 0110512
2019-03-20 13:57 jorge-garcia Status resolved => new
2019-03-20 13:57 jorge-garcia Resolution fixed => open
2019-03-27 16:12 hgbot Checkin
2019-03-27 16:12 hgbot Note Added: 0110704
2019-03-28 13:33 rqueralta File Added: 40232_FinalPatch.patch
2019-04-05 14:38 hgbot Checkin
2019-04-05 14:38 hgbot Note Added: 0111001
2019-04-05 14:38 hgbot Status new => resolved
2019-04-05 14:38 hgbot Resolution open => fixed
2019-04-05 14:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^]
2019-04-08 13:36 jorge-garcia Note Added: 0111022
2019-04-08 13:36 jorge-garcia Status resolved => new
2019-04-08 13:36 jorge-garcia Resolution fixed => open
2019-04-10 23:41 hgbot Checkin
2019-04-10 23:41 hgbot Note Added: 0111068
2019-04-10 23:41 hgbot Status new => resolved
2019-04-10 23:41 hgbot Resolution open => fixed
2019-04-10 23:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b677ab98d08415836ce3c865772471e08b523edd [^]
2019-04-26 11:26 hgbot Checkin
2019-04-26 11:26 hgbot Note Added: 0111356
2019-04-26 11:28 jorge-garcia Note Deleted: 0111356
2019-04-26 11:29 jorge-garcia Note Added: 0111358
2019-04-26 11:29 jorge-garcia Status resolved => closed
2019-04-26 11:29 jorge-garcia Fixed in Version => RR19Q3
2019-04-26 11:40 jorge-garcia Relationship added related to 0040689


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker