Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040232Retail ModulesWeb POSpublic2019-02-18 13:392019-04-26 11:40
Reportersamuel_nicuesa 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q3 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040232: Sales quotation is not saved in Back Office
DescriptionAfter completing a quotation if the cashier press X button before Sync message is displayed, the quotation won't be saved in Back Office.
Steps To Reproduce[POS]

-Configure Chrome performance 6x slowdown
-Create quotation
-Add one product
-Press Amount button and the Quotation will be closed
-Before sync quotation message is shown on top right corner you will need to press X button.

[BO]

-Check that quotation has not been saved.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040689 new Retail Wrong order status if calculate currentcash or updateDocumentSequenceWhenOrderSaved fails in syncrhonize mode 
Attached Filespatch 40232_FinalPatch.patch (5,972) 2019-03-28 13:33
https://issues.openbravo.com/file_download.php?file_id=12802&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-18 13:39samuel_nicuesaNew Issue
2019-02-18 13:39samuel_nicuesaAssigned To => Retail
2019-02-18 13:39samuel_nicuesaResolution time => 1552258800
2019-02-18 13:39samuel_nicuesaTriggers an Emergency Pack => No
2019-02-18 13:41rafarodaIssue Monitored: rafaroda
2019-02-18 20:13rqueraltaAssigned ToRetail => rqueralta
2019-02-18 20:13rqueraltaStatusnew => scheduled
2019-03-07 14:36hgbotCheckin
2019-03-07 14:36hgbotNote Added: 0110282
2019-03-07 14:36hgbotStatusscheduled => resolved
2019-03-07 14:36hgbotResolutionopen => fixed
2019-03-07 14:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^]
2019-03-08 14:07jorge-garciaReview Assigned To => jorge-garcia
2019-03-08 14:28jorge-garciaNote Added: 0110324
2019-03-08 14:28jorge-garciaStatusresolved => new
2019-03-08 14:28jorge-garciaResolutionfixed => open
2019-03-15 23:12hgbotCheckin
2019-03-15 23:12hgbotNote Added: 0110463
2019-03-15 23:12hgbotStatusnew => resolved
2019-03-15 23:12hgbotResolutionopen => fixed
2019-03-15 23:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^]
2019-03-19 19:42hgbotCheckin
2019-03-19 19:42hgbotNote Added: 0110499
2019-03-20 13:57jorge-garciaNote Added: 0110512
2019-03-20 13:57jorge-garciaStatusresolved => new
2019-03-20 13:57jorge-garciaResolutionfixed => open
2019-03-27 16:12hgbotCheckin
2019-03-27 16:12hgbotNote Added: 0110704
2019-03-28 13:33rqueraltaFile Added: 40232_FinalPatch.patch
2019-04-05 14:38hgbotCheckin
2019-04-05 14:38hgbotNote Added: 0111001
2019-04-05 14:38hgbotStatusnew => resolved
2019-04-05 14:38hgbotResolutionopen => fixed
2019-04-05 14:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^]
2019-04-08 13:36jorge-garciaNote Added: 0111022
2019-04-08 13:36jorge-garciaStatusresolved => new
2019-04-08 13:36jorge-garciaResolutionfixed => open
2019-04-10 23:41hgbotCheckin
2019-04-10 23:41hgbotNote Added: 0111068
2019-04-10 23:41hgbotStatusnew => resolved
2019-04-10 23:41hgbotResolutionopen => fixed
2019-04-10 23:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b677ab98d08415836ce3c865772471e08b523edd [^]
2019-04-26 11:26hgbotCheckin
2019-04-26 11:26hgbotNote Added: 0111356
2019-04-26 11:28jorge-garciaNote Deleted: 0111356
2019-04-26 11:29jorge-garciaNote Added: 0111358
2019-04-26 11:29jorge-garciaStatusresolved => closed
2019-04-26 11:29jorge-garciaFixed in Version => RR19Q3
2019-04-26 11:40jorge-garciaRelationship addedrelated to 0040689

Notes
(0110282)
hgbot   
2019-03-07 14:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 88a5c9b52b17a8178dcb80b29903828dc5f4c048
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 04 18:42:19 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88a5c9b52b17a8178dcb80b29903828dc5f4c048 [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Button 'Delete' is disabled until the processing of the order ends

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0110324)
jorge-garcia   
2019-03-08 14:28   
The solution is not complete. If some creates a quotation and a 'OBPOS_PreOrderSave' registered hook launches a cancellation, the process and the scrim will remain in process forever.

Don't start a process depending on document type, the process tapTotalButton makes sense for other type of documents.
(0110463)
hgbot   
2019-03-15 23:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 11 17:11:08 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3e74cbdf2f8dcd36d8602e6ea86363f30c7614c [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Start "tapTotalButton" process for any document type

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0110499)
hgbot   
2019-03-19 19:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f4c894011bbbc690e28c58116934d6ed2b9db3b0
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 18 09:45:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4c894011bbbc690e28c58116934d6ed2b9db3b0 [^]

Related to issue 40232: Sales quotation is not saved in Back Office

- Adde new function to finish a process controller running by searchkey

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0110512)
jorge-garcia   
2019-03-20 13:57   
Processes execution should be a scoped variable in the same context.

OB.UTIL.finishProcessesRunningBySearchKey function is not correct and should not exists (and I don't know why it's needed). In case a process should finish outside the definition scope, two scoped processes should be created instead of using the same.
(0110704)
hgbot   
2019-03-27 16:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e177d56da527e1cfd50a3866a9d684ef8194067b
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Mar 27 12:31:17 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e177d56da527e1cfd50a3866a9d684ef8194067b [^]

Related to issue 40348. Backout of issue 40232. ProcessController.getProcessesRunning no longer exists

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0111001)
hgbot   
2019-04-05 14:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Mar 27 12:05:41 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/564b5b155f9242e5ebc9d1b187c407a8bd0b7f1b [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Button 'Delete' is disabled until the processing of the order ends. A new
process controller registered to this button was added to do it.

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0111022)
jorge-garcia   
2019-04-08 13:36   
Missing end of tapTotalButton process in two places (at least)

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l289 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l381 [^]
(0111068)
hgbot   
2019-04-10 23:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b677ab98d08415836ce3c865772471e08b523edd
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 08 13:48:23 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b677ab98d08415836ce3c865772471e08b523edd [^]

Fixed issue 40232: Sales quotation is not saved in Back Office

- Added missing end of tapTotalButton process in two places.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0111358)
jorge-garcia   
2019-04-26 11:29   
Code reviewed and tested