0040178: Audit fields of 'Open/Close period control' are not updated when Opening/Closing period

diff --git a/src-db/database/model/functions/C_PERIOD_PROCESS.xml b/src-db/database/model/functions/C_PERIOD_PROCESS.xml --- a/src-db/database/model/functions/C_PERIOD_PROCESS.xml +++ b/src-db/database/model/functions/C_PERIOD_PROCESS.xml @@ -1,10 +1,10 @@ <?xml version="1.0"?> - <database name="FUNCTION C_PERIOD_PROCESS"> - <function name="C_PERIOD_PROCESS" type="NULL"> - <parameter name="p_pinstance_id" type="VARCHAR" mode="in"> - <default/> - </parameter> - <body><![CDATA[/************************************************************************* +<database name="FUNCTION C_PERIOD_PROCESS"> + <function name="C_PERIOD_PROCESS" type="NULL"> + <parameter name="p_pinstance_id" type="VARCHAR" mode="in"> + <default/> + </parameter> + <body><![CDATA[/************************************************************************* * The contents of this file are subject to the Compiere Public * License 1.1 ("License"); You may not use this file except in * compliance with the License. You may obtain a copy of the License in @@ -19,7 +19,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU - * Contributions are Copyright (C) 2001-2016 Openbravo, S.L.U. + * Contributions are Copyright (C) 2001-2019 Openbravo, S.L.U. * * Specifically, this derivative work is based upon the following Compiere * file and version. @@ -34,6 +34,7 @@ v_Message VARCHAR2(2000):=''; v_Record_ID VARCHAR2(32); v_Record_ID_Log VARCHAR2(32); + v_AD_User_ID VARCHAR(32):='0'; v_Count2 NUMBER:=0; -- Parameter TYPE RECORD IS REF CURSOR; @@ -60,8 +61,8 @@ BEGIN -- Get Parameters - SELECT Record_ID - INTO v_Record_ID_Log + SELECT Record_ID, AD_User_ID + INTO v_Record_ID_Log, v_AD_User_ID FROM AD_PInstance WHERE AD_PInstance_ID=p_PInstance_ID; @@ -119,7 +120,7 @@ LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; UPDATE C_PeriodControl - SET PeriodStatus='O', openclose='C' + SET PeriodStatus='O', openclose='C', updated=to_date(now()), updatedby=v_AD_User_ID WHERE C_PeriodControl_ID=v_Record_ID AND PeriodStatus<>'P'; END LOOP; @@ -140,7 +141,7 @@ LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; UPDATE C_PeriodControl - SET PeriodStatus='O', openclose='C' + SET PeriodStatus='O', openclose='C', updated=to_date(now()), updatedby=v_AD_User_ID WHERE C_PeriodControl_ID=v_Record_ID AND PeriodStatus<>'P'; END LOOP; @@ -172,7 +173,7 @@ LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; UPDATE C_PeriodControl - SET PeriodStatus='C', openclose='O' + SET PeriodStatus='C', openclose='O', updated=to_date(now()), updatedby=v_AD_User_ID WHERE C_PeriodControl_ID=v_Record_ID AND PeriodStatus<>'P'; END LOOP; @@ -190,7 +191,7 @@ LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; UPDATE C_PeriodControl - SET PeriodStatus='C', openclose='O' + SET PeriodStatus='C', openclose='O', updated=to_date(now()), updatedby=v_AD_User_ID WHERE C_PeriodControl_ID=v_Record_ID AND PeriodStatus<>'P'; END LOOP; @@ -213,7 +214,9 @@ ) LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; - UPDATE C_PeriodControl SET PeriodStatus='P', openclose='O' WHERE C_PeriodControl_ID=v_Record_ID; + UPDATE C_PeriodControl + SET PeriodStatus='P', openclose='O', updated=to_date(now()), updatedby=v_AD_User_ID + WHERE C_PeriodControl_ID=v_Record_ID; END LOOP; ELSIF (p_IsRecursive='N') THEN FOR Cur_Document IN @@ -228,7 +231,9 @@ ) LOOP v_Record_ID:=Cur_Document.C_PERIODCONTROL_ID; - UPDATE C_PeriodControl SET PeriodStatus='P', openclose='O' WHERE C_PeriodControl_ID=v_Record_ID; + UPDATE C_PeriodControl + SET PeriodStatus='P', openclose='O', updated=to_date(now()), updatedby=v_AD_User_ID + WHERE C_PeriodControl_ID=v_Record_ID; END LOOP; END IF; END IF; @@ -239,7 +244,7 @@ ELSE 'O' END FROM c_periodcontrol pc - WHERE pc.c_period_id = p_C_Period_ID) + WHERE pc.c_period_id = p_C_Period_ID), updated=to_date(now()), updatedby=v_AD_User_ID WHERE c_period_id = p_C_Period_ID; --<<FINISH_PROCESS>> @@ -267,5 +272,5 @@ END IF; END C_PERIOD_PROCESS ]]></body> - </function> - </database> + </function> +</database>

Issue History
Date Modified	Username	Field	Change
2019-02-11 13:17	JONHM	New Issue
2019-02-11 13:17	JONHM	Assigned To	=> platform
2019-02-11 13:17	JONHM	Modules	=> Core
2019-02-11 13:17	JONHM	Triggers an Emergency Pack	=> No
2019-03-04 08:48	jarmendariz	Assigned To	platform => jarmendariz
2019-03-04 13:09	jarmendariz	Note Added: 0110188
2019-03-04 13:09	jarmendariz	Assigned To	jarmendariz => Triage Finance
2019-03-04 13:09	jarmendariz	Summary	Some audit fields of 'Open/Close period control' window are not registered => Audit fields of 'Open/Close period control' are not updated when Opening/Closing period
2019-03-04 13:09	jarmendariz	Description Updated	View Revisions
2019-03-04 13:09	jarmendariz	Steps to Reproduce Updated	View Revisions
2019-03-04 13:18	jarmendariz	File Added: 40178.patch
2019-03-04 13:19	jarmendariz	Proposed Solution updated
2019-10-01 06:09	collazoandy4	Assigned To	Triage Finance => collazoandy4
2019-10-01 06:10	collazoandy4	Status	new => scheduled
2019-10-01 15:12	collazoandy4	Note Added: 0114877

Notes
(0110188) jarmendariz (developer) 2019-03-04 13:09	Changed the title and description of this issue because it is not expected to register in the audit trail table the table's audit fields (created, createdby, updated, updatedby). However, those fields should be updated when closing the period

(0114877) collazoandy4 (reporter) 2019-10-01 15:12	Test Plan As System Administrator, set C_Period and C_PeriodControl tables as 'Fully Audited'. As F&B role admin, open window 'Open/Close period control' In the grid view, show column "Updated" both in the main tab and in the Documents one. Select a period of the current year and close it using the "Close Period" button. Check that the audit trail button in the toolbar is enabled and that the Updated columns has updated

Relationships [ Relation Graph ] [ Dependency Graph ]