Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039967
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajorhave not tried2019-01-16 18:142019-02-04 09:17
ReporterasiermartirenaView Statuspublic 
Assigned Toasiermartirena 
PrioritynormalResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision03faa9514189
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039967: The updatePending function is executed too much times

DescriptionThe updatePending function is executed too many times during a single flow, when it should be executed only once setting the final status.
In addition, the function is executed also when the tab (the 'payment' tab) which has the buttons that are being shown/hidden or enabled/disabled is not shown. This function should't be executed in that case.
Steps To ReproduceOpen the Web POS and set a break point in the updatePending function.
Create a ticket in the Web POS --> Check that the updatePending function is being executed even if the payment tab is not shown
Add a payment --> Check that the updatePending function is called many times, when should be called only once
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0040113RR19Q1 closedasiermartirena The updatePending function is executed too much times 
related to defect 0039960 closedranjith_qualiantech_com [RR19Q1] Layaway button remains when making a ticket layaway and then receipt again 

-  Notes
(0109030)
hgbot (developer)
2019-01-21 09:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 03faa9514189498f020b85f699de2573fc1ddcfb
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Jan 18 10:32:18 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^]

Fixed issue 39967: The updatePending function is executed too much times

The updatePending is now called only when clicking in the payment tab, when changing the business partner (and the focus is in the payment tab), when the adjustPayment function is called (and the focus is in the payment tab and also the calculateReceipt process is not being executed) and after the calculateReceipt process has been finished (and the focus is in the payment tab).

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0109034)
hgbot (developer)
2019-01-21 10:11

 Repository: tools/automation/pi-mobile
Changeset: 3c8428999f06718623b276b11d2f6d30781bb1cb
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Sat Jan 19 11:09:46 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3c8428999f06718623b276b11d2f6d30781bb1cb [^]

Related to issue 39967: Modified tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/taxexempt/I37958_VerifyOrderLineWithTaxExempt.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I36324_CancelAndRplcInvOrdWithReturn_AddProd.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31175_LayawayVerifyPayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/ChangeBPOffline.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/MultiPriceListOffline.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/SALa090_CreateSaleUsingPercentages.java
---
(0109062)
gorka_gil (administrator)
2019-01-22 10:57

 Repository: tools/automation/pi-mobile
Changeset: 2deac30c786a
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Jan 22 10:56:00 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2deac30c786a [^]

Related to 39967: Fix test I32814_VerifyMessagesPaymentView

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32814_VerifyMessagesPaymentView.java

- Issue History
Date Modified Username Field Change
2019-01-16 18:14 asiermartirena New Issue
2019-01-16 18:14 asiermartirena Assigned To => asiermartirena
2019-01-16 18:14 asiermartirena OBNetwork customer => No
2019-01-16 18:14 asiermartirena Triggers an Emergency Pack => No
2019-01-21 09:54 hgbot Checkin
2019-01-21 09:54 hgbot Note Added: 0109030
2019-01-21 09:54 hgbot Status new => resolved
2019-01-21 09:54 hgbot Resolution open => fixed
2019-01-21 09:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^]
2019-01-21 10:11 hgbot Checkin
2019-01-21 10:11 hgbot Note Added: 0109034
2019-01-22 10:57 gorka_gil Note Added: 0109062
2019-02-04 09:16 marvintm Status resolved => new
2019-02-04 09:16 marvintm Resolution fixed => open
2019-02-04 09:17 marvintm Status new => scheduled
2019-02-04 09:17 marvintm Status scheduled => resolved
2019-02-04 09:17 marvintm Fixed in Version => RR19Q2
2019-02-04 09:17 marvintm Resolution open => fixed
2019-02-04 09:17 marvintm Review Assigned To => marvintm
2019-02-04 09:17 marvintm Status resolved => closed
2019-02-04 17:37 jorge-garcia Relationship added related to 0039960

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker