Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039967Retail ModulesWeb POSpublic2019-01-16 18:142019-02-04 09:17
Reporterasiermartirena 
Assigned Toasiermartirena 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039967: The updatePending function is executed too much times
DescriptionThe updatePending function is executed too many times during a single flow, when it should be executed only once setting the final status.
In addition, the function is executed also when the tab (the 'payment' tab) which has the buttons that are being shown/hidden or enabled/disabled is not shown. This function should't be executed in that case.
Steps To ReproduceOpen the Web POS and set a break point in the updatePending function.
Create a ticket in the Web POS --> Check that the updatePending function is being executed even if the payment tab is not shown
Add a payment --> Check that the updatePending function is called many times, when should be called only once
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040113RR19Q1 closed asiermartirena The updatePending function is executed too much times 
related to defect 0039960 closed ranjith_qualiantech_com [RR19Q1] Layaway button remains when making a ticket layaway and then receipt again 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-16 18:14asiermartirenaNew Issue
2019-01-16 18:14asiermartirenaAssigned To => asiermartirena
2019-01-16 18:14asiermartirenaOBNetwork customer => No
2019-01-16 18:14asiermartirenaTriggers an Emergency Pack => No
2019-01-21 09:54hgbotCheckin
2019-01-21 09:54hgbotNote Added: 0109030
2019-01-21 09:54hgbotStatusnew => resolved
2019-01-21 09:54hgbotResolutionopen => fixed
2019-01-21 09:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^]
2019-01-21 10:11hgbotCheckin
2019-01-21 10:11hgbotNote Added: 0109034
2019-01-22 10:57gorka_gilNote Added: 0109062
2019-02-04 09:16marvintmStatusresolved => new
2019-02-04 09:16marvintmResolutionfixed => open
2019-02-04 09:17marvintmStatusnew => scheduled
2019-02-04 09:17marvintmStatusscheduled => resolved
2019-02-04 09:17marvintmFixed in Version => RR19Q2
2019-02-04 09:17marvintmResolutionopen => fixed
2019-02-04 09:17marvintmReview Assigned To => marvintm
2019-02-04 09:17marvintmStatusresolved => closed
2019-02-04 17:37jorge-garciaRelationship addedrelated to 0039960

Notes
(0109030)
hgbot   
2019-01-21 09:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 03faa9514189498f020b85f699de2573fc1ddcfb
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Jan 18 10:32:18 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^]

Fixed issue 39967: The updatePending function is executed too much times

The updatePending is now called only when clicking in the payment tab, when changing the business partner (and the focus is in the payment tab), when the adjustPayment function is called (and the focus is in the payment tab and also the calculateReceipt process is not being executed) and after the calculateReceipt process has been finished (and the focus is in the payment tab).

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0109034)
hgbot   
2019-01-21 10:11   
Repository: tools/automation/pi-mobile
Changeset: 3c8428999f06718623b276b11d2f6d30781bb1cb
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Sat Jan 19 11:09:46 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3c8428999f06718623b276b11d2f6d30781bb1cb [^]

Related to issue 39967: Modified tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/taxexempt/I37958_VerifyOrderLineWithTaxExempt.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I36324_CancelAndRplcInvOrdWithReturn_AddProd.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31175_LayawayVerifyPayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/ChangeBPOffline.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/MultiPriceListOffline.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/SALa090_CreateSaleUsingPercentages.java
---
(0109062)
gorka_gil   
2019-01-22 10:57   
Repository: tools/automation/pi-mobile
Changeset: 2deac30c786a
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Jan 22 10:56:00 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2deac30c786a [^]

Related to 39967: Fix test I32814_VerifyMessagesPaymentView

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32814_VerifyMessagesPaymentView.java