0039846: baseUnitPrice property needs to be sent to ExternalOrderLoader although correct property name is baseGrossUnitPrice

Description

baseUnitPrice property needs to be sent to ExternalOrderLoader to generate promotions although correct property name is baseGrossUnitPrice

Steps To Reproduce

Run ExternalOrderLoader.importOrder() with a json including a orderLine with following JSONArray:
"promotions": [
  {
    "discountRule": "809BB26E4C61443FABEE87A54040311D",
    "quantity": 1,
    "amount": 35.2,
    "baseGrossUnitPrice": 278.91,
    "unitDiscount": 35.2,

  }
]

Check ExternalOrderLoader fails because "baseUnitPrice" property is missing inside promotions JSONArray.

Run ExternalOrderLoader.importOrder() with a json including a orderLine with following JSONArray:
"promotions": [
  {
    "discountRule": "809BB26E4C61443FABEE87A54040311D",
    "quantity": 1,
    "amount": 35.2,
    "baseUnitPrice": 278.91,
    "unitDiscount": 35.2,

  }
]

Check created C_OrderLine_Offer.priceoffergross is zero.

Problem is that OrderLineOffer property is "baseGrossUnitPrice", not "baseUnitPrice".

Proposed Solution

Remove following line from ExternalOrderLoader:
check(json, "baseUnitPrice", msg);

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0108705) hgbot (developer) 2018-12-20 19:37	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f0548f5c5ccacc7e0774ae07bf6b609b03412e57 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Dec 20 19:36:40 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0548f5c5ccacc7e0774ae07bf6b609b03412e57 [^] Fixes issue 39846: Remove baseUnitPrice property check from ExternalOrderLoader --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2018-12-20 19:35	aferraz	New Issue
2018-12-20 19:35	aferraz	Assigned To	=> aferraz
2018-12-20 19:35	aferraz	Triggers an Emergency Pack	=> No
2018-12-20 19:37	hgbot	Checkin
2018-12-20 19:37	hgbot	Note Added: 0108705
2018-12-20 19:37	hgbot	Status	new => resolved
2018-12-20 19:37	hgbot	Resolution	open => fixed
2018-12-20 19:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0548f5c5ccacc7e0774ae07bf6b609b03412e57 [^]
2018-12-20 19:42	aferraz	Review Assigned To	=> marvintm
2018-12-21 16:38	marvintm	Status	resolved => closed
2018-12-21 16:38	marvintm	Fixed in Version	=> RR19Q1