Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039846Retail ModulesWeb POSpublic2018-12-20 19:352018-12-21 16:38
aferraz 
aferraz 
normalminorhave not tried
closedfixed 
5
 
RR19Q1RR19Q1 
marvintm
No
0039846: baseUnitPrice property needs to be sent to ExternalOrderLoader although correct property name is baseGrossUnitPrice
baseUnitPrice property needs to be sent to ExternalOrderLoader to generate promotions although correct property name is baseGrossUnitPrice
Run ExternalOrderLoader.importOrder() with a json including a orderLine with following JSONArray:
"promotions": [
  {
    "discountRule": "809BB26E4C61443FABEE87A54040311D",
    "quantity": 1,
    "amount": 35.2,
    "baseGrossUnitPrice": 278.91,
    "unitDiscount": 35.2,
    
  }
]

Check ExternalOrderLoader fails because "baseUnitPrice" property is missing inside promotions JSONArray.

Run ExternalOrderLoader.importOrder() with a json including a orderLine with following JSONArray:
"promotions": [
  {
    "discountRule": "809BB26E4C61443FABEE87A54040311D",
    "quantity": 1,
    "amount": 35.2,
    "baseUnitPrice": 278.91,
    "unitDiscount": 35.2,
    
  }
]

Check created C_OrderLine_Offer.priceoffergross is zero.

Problem is that OrderLineOffer property is "baseGrossUnitPrice", not "baseUnitPrice".
Remove following line from ExternalOrderLoader:
check(json, "baseUnitPrice", msg);
No tags attached.
Issue History
2018-12-20 19:35aferrazNew Issue
2018-12-20 19:35aferrazAssigned To => aferraz
2018-12-20 19:35aferrazTriggers an Emergency Pack => No
2018-12-20 19:37hgbotCheckin
2018-12-20 19:37hgbotNote Added: 0108705
2018-12-20 19:37hgbotStatusnew => resolved
2018-12-20 19:37hgbotResolutionopen => fixed
2018-12-20 19:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0548f5c5ccacc7e0774ae07bf6b609b03412e57 [^]
2018-12-20 19:42aferrazReview Assigned To => marvintm
2018-12-21 16:38marvintmStatusresolved => closed
2018-12-21 16:38marvintmFixed in Version => RR19Q1

Notes
(0108705)
hgbot   
2018-12-20 19:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f0548f5c5ccacc7e0774ae07bf6b609b03412e57
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Dec 20 19:36:40 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0548f5c5ccacc7e0774ae07bf6b609b03412e57 [^]

Fixes issue 39846: Remove baseUnitPrice property check from ExternalOrderLoader

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---