Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039685
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] External Data Integrationminorhave not tried2018-11-23 10:262019-01-15 11:27
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision2ceb47e7d363
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToAugustoMauch
Regression introduced in release
Summary

0039685: EDL Request Line Error Message length should be controlled when setting it

DescriptionEDL Request Line Error Message length should be controlled when setting it. In case the error message provided is higher that the maximum allowed it can cause trouble when managing the error state of the request line. Because this can lead to have the import entry status in error and the related EDL request line status not being updated accordingly.

This is a sample trace of an import entry error, caused because of trying to set an error message higher than the maximum allowed:

org.openbravo.base.validation.ValidationException: errorMsg: <errorMsg> is too long, it has length <length>, the maximum allowed length is 2000
                at org.openbravo.base.model.Property.checkIsValidValue(Property.java:833)
                at org.openbravo.base.structure.BaseOBObject.set(BaseOBObject.java:264)
                at org.openbravo.externaldata.integration.OBEDLRequestLine.setErrorMsg(OBEDLRequestLine.java:184)
                at org.openbravo.externaldata.integration.process.ProcessRequest.processRequestLine(ProcessRequest.java:513)
                at org.openbravo.externaldata.integration.process.EDLImportEntryProcessor$EDLEntryProcessRunnable.processEntry(EDLImportEntryProcessor.java:95)
                at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:369)
                at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:290)
                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                at java.lang.Thread.run(Thread.java:748)
Steps To ReproduceIn description
Proposed SolutionLimit the size of the error message before setting it to the EDL request line in case it is higher to the maximum allowed.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039949 newTriage Platform Base The maximum length of EDLRequest.response should be checked before setting it 

-  Notes
(0108074)
hgbot (developer)
2018-11-23 11:34

 Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 2ceb47e7d36396f9b40bcba5bdfc1c9ee58377fc
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Nov 23 11:33:13 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/2ceb47e7d36396f9b40bcba5bdfc1c9ee58377fc [^]

fixes bug 39685: Check EDL Request Line Error Message length before setting it

---
M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
A src/org/openbravo/externaldata/integration/util/EDLUtils.java
---
(0108371)
AugustoMauch (administrator)
2018-12-10 16:36

 Code reviewed and verified

- Issue History
Date Modified Username Field Change
2018-11-23 10:26 caristu New Issue
2018-11-23 10:26 caristu Assigned To => caristu
2018-11-23 10:28 caristu Summary Request Line Error Message length should be controlled when setting it => EDL Request Line Error Message length should be controlled when setting it
2018-11-23 10:28 caristu Description Updated View Revisions
2018-11-23 10:28 caristu Proposed Solution updated
2018-11-23 10:28 caristu Proposed Solution updated
2018-11-23 10:31 caristu Description Updated View Revisions
2018-11-23 10:31 caristu Proposed Solution updated
2018-11-23 10:39 caristu Review Assigned To => AugustoMauch
2018-11-23 10:43 caristu Description Updated View Revisions
2018-11-23 10:44 caristu Description Updated View Revisions
2018-11-23 11:34 hgbot Checkin
2018-11-23 11:34 hgbot Note Added: 0108074
2018-11-23 11:34 hgbot Status new => resolved
2018-11-23 11:34 hgbot Resolution open => fixed
2018-11-23 11:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/2ceb47e7d36396f9b40bcba5bdfc1c9ee58377fc [^]
2018-11-23 11:55 caristu Issue cloned 0039687
2018-12-10 16:36 AugustoMauch Note Added: 0108371
2018-12-10 16:36 AugustoMauch Status resolved => closed
2019-01-15 11:27 AugustoMauch Issue cloned 0039949
2019-01-15 11:28 AugustoMauch Relationship added related to 0039949

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker