0039685: EDL Request Line Error Message length should be controlled when setting it

0039685

Modules

External Data Integration

public

2018-11-23 10:26

2019-01-15 11:27

Reporter

caristu

Assigned To

caristu

Priority

high

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

AugustoMauch

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0039685: EDL Request Line Error Message length should be controlled when setting it

Description

EDL Request Line Error Message length should be controlled when setting it. In case the error message provided is higher that the maximum allowed it can cause trouble when managing the error state of the request line. Because this can lead to have the import entry status in error and the related EDL request line status not being updated accordingly.

This is a sample trace of an import entry error, caused because of trying to set an error message higher than the maximum allowed:

org.openbravo.base.validation.ValidationException: errorMsg: <errorMsg> is too long, it has length <length>, the maximum allowed length is 2000
                at org.openbravo.base.model.Property.checkIsValidValue(Property.java:833)
                at org.openbravo.base.structure.BaseOBObject.set(BaseOBObject.java:264)
                at org.openbravo.externaldata.integration.OBEDLRequestLine.setErrorMsg(OBEDLRequestLine.java:184)
                at org.openbravo.externaldata.integration.process.ProcessRequest.processRequestLine(ProcessRequest.java:513)
                at org.openbravo.externaldata.integration.process.EDLImportEntryProcessor$EDLEntryProcessRunnable.processEntry(EDLImportEntryProcessor.java:95)
                at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:369)
                at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:290)
                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                at java.lang.Thread.run(Thread.java:748)

Steps To Reproduce

In description

Proposed Solution

Limit the size of the error message before setting it to the EDL request line in case it is higher to the maximum allowed.

Additional Information