Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039440
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Gift cards and gift vouchersmajoralways2018-10-11 17:562018-11-16 09:50
Reportersamuel_nicuesaView Statuspublic 
Assigned Torqueralta 
PriorityhighResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revision8f1fe9a0d418
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039440: A Credit note is closed without any sales order associated.

DescriptionA Credit note is closed without any sales order associated, it happens if you have bad internet connection.
Steps To Reproduce[POS]

-Create one Credit Note
(Create ticket - add product and pay it - verified return - select CNote as a payment)
-Create a new Ticket and add one product
-Select Credit Note payment method and find the Credit Note created
-Using slow internet press apply button.
-Make sure you don't have internet connection after pressing apply button
-You will see that your credit note has not been added to the receipt but it has been used in Back office see :(Gift card instance window).

-A new transaction has been created but it is not linked to the sales order.

See the attached video
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0107703)
hgbot (developer)
2018-10-31 19:50

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 59f52df7ac7fd37ee44700fb13f75ba04a80d75e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Oct 31 14:15:59 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If jsonsent.optString("orderline") is empty the process is canceled

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107705)
hgbot (developer)
2018-11-01 03:11

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 9548f7b552482f0dac8357ba88c85f74ab80e2de
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Oct 31 22:10:19 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9548f7b552482f0dac8357ba88c85f74ab80e2de [^]

Related to issue 39440: Backed out changeset: 59f52df7ac7f

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107727)
hgbot (developer)
2018-11-04 04:43

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 9355bdce53f34934c5bfadf6bf36f67e2e6564bf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Nov 03 23:41:47 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If jsonsent.optString("orderline") is empty the process is canceled

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107762)
hgbot (developer)
2018-11-06 03:13

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 8f1fe9a0d4184793d541c3725fd39b9453432f2f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Nov 05 16:04:57 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/8f1fe9a0d4184793d541c3725fd39b9453432f2f [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If ConsumeGiftCardAmount process fail by time out, RevertGiftCardAmount is
executed to revert the Gift Card Amount

---
M src/org/openbravo/retail/giftcards/RevertGiftCardAmount.java
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---
(0107765)
hgbot (developer)
2018-11-06 12:09

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: f11c76377389df3a7341b373e8258ea031cf3bcf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Nov 06 06:09:24 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f11c76377389df3a7341b373e8258ea031cf3bcf [^]

Related to issue 39440: A Credit note is closed without any sales order
associated

---
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---

- Issue History
Date Modified Username Field Change
2018-10-11 17:56 samuel_nicuesa New Issue
2018-10-11 17:56 samuel_nicuesa Assigned To => Retail
2018-10-11 17:56 samuel_nicuesa Triggers an Emergency Pack => No
2018-10-15 09:08 rafaroda Issue Monitored: rafaroda
2018-10-15 23:40 rqueralta Assigned To Retail => rqueralta
2018-10-16 14:44 rqueralta Status new => scheduled
2018-10-31 19:50 hgbot Checkin
2018-10-31 19:50 hgbot Note Added: 0107703
2018-10-31 19:50 hgbot Status scheduled => resolved
2018-10-31 19:50 hgbot Resolution open => fixed
2018-10-31 19:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^]
2018-11-01 03:11 hgbot Checkin
2018-11-01 03:11 hgbot Note Added: 0107705
2018-11-02 10:24 marvintm Status resolved => new
2018-11-02 10:24 marvintm Resolution fixed => open
2018-11-02 10:25 marvintm Status new => scheduled
2018-11-04 04:43 hgbot Checkin
2018-11-04 04:43 hgbot Note Added: 0107727
2018-11-04 04:43 hgbot Status scheduled => resolved
2018-11-04 04:43 hgbot Resolution open => fixed
2018-11-04 04:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^]
2018-11-04 15:00 rqueralta Status resolved => new
2018-11-04 15:00 rqueralta Resolution fixed => open
2018-11-04 15:00 rqueralta Status new => scheduled
2018-11-06 03:13 hgbot Checkin
2018-11-06 03:13 hgbot Note Added: 0107762
2018-11-06 03:13 hgbot Status scheduled => resolved
2018-11-06 03:13 hgbot Resolution open => fixed
2018-11-06 03:13 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/8f1fe9a0d4184793d541c3725fd39b9453432f2f [^]
2018-11-06 12:09 hgbot Checkin
2018-11-06 12:09 hgbot Note Added: 0107765
2018-11-16 09:50 marvintm Review Assigned To => marvintm
2018-11-16 09:50 marvintm Status resolved => closed
2018-11-16 09:50 marvintm Fixed in Version => RR19Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker