Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039440Retail ModulesGift cards and gift voucherspublic2018-10-11 17:562018-12-21 16:29
samuel_nicuesa 
rqueralta 
highmajoralways
newopen 
5
pi 
 
marvintm
No
0039440: A Credit note is closed without any sales order associated.
A Credit note is closed without any sales order associated, it happens if you have bad internet connection.
[POS]

-Create one Credit Note
(Create ticket - add product and pay it - verified return - select CNote as a payment)
-Create a new Ticket and add one product
-Select Credit Note payment method and find the Credit Note created
-Using slow internet press apply button.
-Make sure you don't have internet connection after pressing apply button
-You will see that your credit note has not been added to the receipt but it has been used in Back office see :(Gift card instance window).

-A new transaction has been created but it is not linked to the sales order.

See the attached video
No tags attached.
png IssueCNote.png (130,500) 2018-12-10 16:03
https://issues.openbravo.com/file_download.php?file_id=12419&type=bug
png
Issue History
2018-10-11 17:56samuel_nicuesaNew Issue
2018-10-11 17:56samuel_nicuesaAssigned To => Retail
2018-10-11 17:56samuel_nicuesaTriggers an Emergency Pack => No
2018-10-15 09:08rafarodaIssue Monitored: rafaroda
2018-10-15 23:40rqueraltaAssigned ToRetail => rqueralta
2018-10-16 14:44rqueraltaStatusnew => scheduled
2018-10-31 19:50hgbotCheckin
2018-10-31 19:50hgbotNote Added: 0107703
2018-10-31 19:50hgbotStatusscheduled => resolved
2018-10-31 19:50hgbotResolutionopen => fixed
2018-10-31 19:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^]
2018-11-01 03:11hgbotCheckin
2018-11-01 03:11hgbotNote Added: 0107705
2018-11-02 10:24marvintmStatusresolved => new
2018-11-02 10:24marvintmResolutionfixed => open
2018-11-02 10:25marvintmStatusnew => scheduled
2018-11-04 04:43hgbotCheckin
2018-11-04 04:43hgbotNote Added: 0107727
2018-11-04 04:43hgbotStatusscheduled => resolved
2018-11-04 04:43hgbotResolutionopen => fixed
2018-11-04 04:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^]
2018-11-04 15:00rqueraltaStatusresolved => new
2018-11-04 15:00rqueraltaResolutionfixed => open
2018-11-04 15:00rqueraltaStatusnew => scheduled
2018-11-06 03:13hgbotCheckin
2018-11-06 03:13hgbotNote Added: 0107762
2018-11-06 03:13hgbotStatusscheduled => resolved
2018-11-06 03:13hgbotResolutionopen => fixed
2018-11-06 03:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/8f1fe9a0d4184793d541c3725fd39b9453432f2f [^]
2018-11-06 12:09hgbotCheckin
2018-11-06 12:09hgbotNote Added: 0107765
2018-11-16 09:50marvintmReview Assigned To => marvintm
2018-11-16 09:50marvintmStatusresolved => closed
2018-11-16 09:50marvintmFixed in Version => RR19Q1
2018-11-26 13:42samuel_nicuesaNote Added: 0108104
2018-12-10 16:02samuel_nicuesaNote Added: 0108363
2018-12-10 16:02samuel_nicuesaStatusclosed => new
2018-12-10 16:02samuel_nicuesaResolutionfixed => open
2018-12-10 16:02samuel_nicuesaFixed in VersionRR19Q1 =>
2018-12-10 16:03samuel_nicuesaFile Added: IssueCNote.png
2018-12-21 16:29marvintmTypedefect => design defect

Notes
(0107703)
hgbot   
2018-10-31 19:50   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 59f52df7ac7fd37ee44700fb13f75ba04a80d75e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Oct 31 14:15:59 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/59f52df7ac7fd37ee44700fb13f75ba04a80d75e [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If jsonsent.optString("orderline") is empty the process is canceled

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107705)
hgbot   
2018-11-01 03:11   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 9548f7b552482f0dac8357ba88c85f74ab80e2de
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Oct 31 22:10:19 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9548f7b552482f0dac8357ba88c85f74ab80e2de [^]

Related to issue 39440: Backed out changeset: 59f52df7ac7f

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107727)
hgbot   
2018-11-04 04:43   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 9355bdce53f34934c5bfadf6bf36f67e2e6564bf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Nov 03 23:41:47 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9355bdce53f34934c5bfadf6bf36f67e2e6564bf [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If jsonsent.optString("orderline") is empty the process is canceled

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
---
(0107762)
hgbot   
2018-11-06 03:13   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 8f1fe9a0d4184793d541c3725fd39b9453432f2f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Nov 05 16:04:57 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/8f1fe9a0d4184793d541c3725fd39b9453432f2f [^]

Fixed issue 39440: A Credit note is closed without any sales order associated

- If ConsumeGiftCardAmount process fail by time out, RevertGiftCardAmount is
executed to revert the Gift Card Amount

---
M src/org/openbravo/retail/giftcards/RevertGiftCardAmount.java
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---
(0107765)
hgbot   
2018-11-06 12:09   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: f11c76377389df3a7341b373e8258ea031cf3bcf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Nov 06 06:09:24 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f11c76377389df3a7341b373e8258ea031cf3bcf [^]

Related to issue 39440: A Credit note is closed without any sales order
associated

---
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---
(0108104)
samuel_nicuesa   
2018-11-26 13:42   
This changeset is also part of this issue:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/fbbce021376d [^]
(0108363)
samuel_nicuesa   
2018-12-10 16:02   
Hi!
I thought that the fix was working fine but I am be able to reproduce the error.
Can you check it ?