Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039435
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorrandom2018-10-11 10:232019-03-04 08:42
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision309b21f1b99e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039435: Javascript error when a keyup event is fired without key information

DescriptionUnder unknown circumstances, the WebPOS starts firing keyup events randomly on the focusKeeper, simply by clicking on application buttons (i.e. Create New Receipt).
These events have no associated key information, which causes javascript errors in the globalKeypressHandler function.
Steps To Reproduce-
Proposed SolutionAttached a patch that adds a small sanity check in the globalKeypressHandler function to return if this error is reproduced again
TagsNo tags attached.
Attached Files? file icon Issue39435.export [^] (1,105 bytes) 2018-10-11 10:26
diff file icon I39435_v2-1.diff [^] (986 bytes) 2019-02-28 16:06 [Show Content]
diff file icon I39435_v2-2.diff [^] (1,610 bytes) 2019-02-28 16:06 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039899RR19Q2 closedguilleaer Under certain circumstances error is shown by globalKeypressHandler 

-  Notes
(0110100)
hgbot (developer)
2019-02-27 10:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6a974c2459ca8a5fc7998e312fe3de7ff96dc919
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 27 14:38:52 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^]

Fixed issue 39435 : Prevent Keypress handler functionality if key value is not presents

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0110124)
jorge-garcia (viewer)
2019-02-28 16:05

 The solution is correct, but there was a previous commit which "almost fix" the problem reported here (see related issue).

It's better to don't check the same thing twice. So I attached two possible patches that could be applied.

IMHO I prefer option I39435_v2-1.diff over option I39435_v2-2.diff
(0110161)
hgbot (developer)
2019-03-02 11:44

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 309b21f1b99ee13d6ae75595c0161d5d15f63b39
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Mar 02 16:14:10 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/309b21f1b99ee13d6ae75595c0161d5d15f63b39 [^]

Fixed issue 39435 : Prevent Keypress handler functionality if key value is not presents

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0110171)
jorge-garcia (viewer)
2019-03-04 08:42

 Code reviewed and tested

- Issue History
Date Modified Username Field Change
2018-10-11 10:23 aaroncalero New Issue
2018-10-11 10:23 aaroncalero Assigned To => Retail
2018-10-11 10:23 aaroncalero OBNetwork customer => No
2018-10-11 10:23 aaroncalero Triggers an Emergency Pack => No
2018-10-11 10:26 aaroncalero File Added: Issue39435.export
2019-02-26 10:05 marvintm OBNetwork customer No => Gold
2019-02-26 10:05 marvintm Resolution time => 1552950000
2019-02-26 15:14 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-02-27 10:09 ranjith_qualiantech_com Status new => scheduled
2019-02-27 10:10 hgbot Checkin
2019-02-27 10:10 hgbot Note Added: 0110100
2019-02-27 10:10 hgbot Status scheduled => resolved
2019-02-27 10:10 hgbot Resolution open => fixed
2019-02-27 10:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^]
2019-02-28 15:51 jorge-garcia Relationship added related to 0039899
2019-02-28 16:05 jorge-garcia Note Added: 0110124
2019-02-28 16:05 jorge-garcia Status resolved => new
2019-02-28 16:05 jorge-garcia Resolution fixed => open
2019-02-28 16:06 jorge-garcia File Added: I39435_v2-1.diff
2019-02-28 16:06 jorge-garcia File Added: I39435_v2-2.diff
2019-02-28 16:07 jorge-garcia Review Assigned To => jorge-garcia
2019-03-01 14:38 ranjith_qualiantech_com Status new => scheduled
2019-03-02 11:44 hgbot Checkin
2019-03-02 11:44 hgbot Note Added: 0110161
2019-03-02 11:44 hgbot Status scheduled => resolved
2019-03-02 11:44 hgbot Resolution open => fixed
2019-03-02 11:44 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/309b21f1b99ee13d6ae75595c0161d5d15f63b39 [^]
2019-03-04 08:42 jorge-garcia Note Added: 0110171
2019-03-04 08:42 jorge-garcia Status resolved => closed
2019-03-04 08:42 jorge-garcia Fixed in Version => RR19Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker