Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039435Retail ModulesWeb POSpublic2018-10-11 10:232019-03-04 08:42
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039435: Javascript error when a keyup event is fired without key information
DescriptionUnder unknown circumstances, the WebPOS starts firing keyup events randomly on the focusKeeper, simply by clicking on application buttons (i.e. Create New Receipt).
These events have no associated key information, which causes javascript errors in the globalKeypressHandler function.
Steps To Reproduce-
Proposed SolutionAttached a patch that adds a small sanity check in the globalKeypressHandler function to return if this error is reproduced again
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039899RR19Q2 closed guilleaer Under certain circumstances error is shown by globalKeypressHandler 
Attached Files? Issue39435.export (1,105) 2018-10-11 10:26
https://issues.openbravo.com/file_download.php?file_id=12257&type=bug
diff I39435_v2-1.diff (986) 2019-02-28 16:06
https://issues.openbravo.com/file_download.php?file_id=12691&type=bug
diff I39435_v2-2.diff (1,610) 2019-02-28 16:06
https://issues.openbravo.com/file_download.php?file_id=12692&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-11 10:23aaroncaleroNew Issue
2018-10-11 10:23aaroncaleroAssigned To => Retail
2018-10-11 10:23aaroncaleroTriggers an Emergency Pack => No
2018-10-11 10:26aaroncaleroFile Added: Issue39435.export
2019-02-26 10:05marvintmResolution time => 1552950000
2019-02-26 15:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-02-27 10:09ranjith_qualiantech_comStatusnew => scheduled
2019-02-27 10:10hgbotCheckin
2019-02-27 10:10hgbotNote Added: 0110100
2019-02-27 10:10hgbotStatusscheduled => resolved
2019-02-27 10:10hgbotResolutionopen => fixed
2019-02-27 10:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^]
2019-02-28 15:51jorge-garciaRelationship addedrelated to 0039899
2019-02-28 16:05jorge-garciaNote Added: 0110124
2019-02-28 16:05jorge-garciaStatusresolved => new
2019-02-28 16:05jorge-garciaResolutionfixed => open
2019-02-28 16:06jorge-garciaFile Added: I39435_v2-1.diff
2019-02-28 16:06jorge-garciaFile Added: I39435_v2-2.diff
2019-02-28 16:07jorge-garciaReview Assigned To => jorge-garcia
2019-03-01 14:38ranjith_qualiantech_comStatusnew => scheduled
2019-03-02 11:44hgbotCheckin
2019-03-02 11:44hgbotNote Added: 0110161
2019-03-02 11:44hgbotStatusscheduled => resolved
2019-03-02 11:44hgbotResolutionopen => fixed
2019-03-02 11:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/309b21f1b99ee13d6ae75595c0161d5d15f63b39 [^]
2019-03-04 08:42jorge-garciaNote Added: 0110171
2019-03-04 08:42jorge-garciaStatusresolved => closed
2019-03-04 08:42jorge-garciaFixed in Version => RR19Q2

Notes
(0110100)
hgbot   
2019-02-27 10:10   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6a974c2459ca8a5fc7998e312fe3de7ff96dc919
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 27 14:38:52 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a974c2459ca8a5fc7998e312fe3de7ff96dc919 [^]

Fixed issue 39435 : Prevent Keypress handler functionality if key value is not presents

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0110124)
jorge-garcia   
2019-02-28 16:05   
The solution is correct, but there was a previous commit which "almost fix" the problem reported here (see related issue).

It's better to don't check the same thing twice. So I attached two possible patches that could be applied.

IMHO I prefer option I39435_v2-1.diff over option I39435_v2-2.diff
(0110161)
hgbot   
2019-03-02 11:44   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 309b21f1b99ee13d6ae75595c0161d5d15f63b39
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Mar 02 16:14:10 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/309b21f1b99ee13d6ae75595c0161d5d15f63b39 [^]

Fixed issue 39435 : Prevent Keypress handler functionality if key value is not presents

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0110171)
jorge-garcia   
2019-03-04 08:42   
Code reviewed and tested