Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039428
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSminoralways2018-07-20 12:462018-10-18 13:05
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR18Q3.2
StatusclosedFix in branchFixed in SCM revision1198e2c11bb4
ProjectionnoneETAnoneTarget VersionRR18Q3.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039428: Do not set terminalName with empty value

DescriptionSince we added localStorage API, we save items in localStorage with the appName as prefix (WEBPOS.terminalName).
There is a case where we try to getItem but appName is not yet defined in OB.MobileApp.model, so we cannot get it from localStorage and we get null value.
Steps To ReproducePut a breakpoint in login-model.js in the line:

      me.setTerminalName(OB.UTIL.localStorage.getItem('terminalAuthentication', me.get('appName')) === 'Y' ? OB.UTIL.localStorage.getItem('terminalName', me.get('appName')) : OB.UTIL.getParameterByName("terminal"));

just before the line:

      OB.UTIL.HookManager.registerHook('OBMOBC_InitActions', function (args, c) {

Load web Pos and see that:

- OB.MobileApp.model is undefined so we cannot get the appName
- OB.UTIL.localStorage.getItem('terminalAuthentication') is null
- OB.UTIL.localStorage.getItem('terminalName')
Proposed SolutionChange the localStorage API adding the ability pass the appName. After this fix, we will be able to load items from localStorage before appName is defined in OB.MobileApp.model.

Example:
      me.setTerminalName(OB.UTIL.localStorage.getItem('terminalAuthentication', me.get('appName')) === 'Y' ? OB.UTIL.localStorage.getItem('terminalName', me.get('appName')) : OB.UTIL.getParameterByName("terminal"));

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0039009 closedmigueldejuana Do not set terminalName with empty value 

-  Notes
(0107341)
hgbot (developer)
2018-10-16 16:24

 Repository: retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core
Changeset: 9c6008e24116a27620858cf38fb818f5401de608
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 16 16:22:24 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core/rev/9c6008e24116a27620858cf38fb818f5401de608 [^]

Fixed issue 0039428: Do not set terminalName with empty value

- Add the ability to pass appName in case OB.MobileApp.model is not defined yet

---
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0107342)
hgbot (developer)
2018-10-16 16:24

 Repository: retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal
Changeset: 1198e2c11bb4cba53468763f73d5fcb53a42576c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Oct 16 16:23:15 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal/rev/1198e2c11bb4cba53468763f73d5fcb53a42576c [^]

Fixed issue 0039428: Do not set terminalName with empty value

- At this point OB.MobileApp.model is not defined so we cannot get appName to get items from localStorage. All localStoragegetItem will return null because this problem(until OB.MobileApp.model is defined) As we already know the appName, pass it as parameter to loscalStorage API.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---

- Issue History
Date Modified Username Field Change
2018-10-09 19:03 marvintm Type defect => backport
2018-10-09 19:03 marvintm Target Version => RR18Q3.2
2018-10-16 16:24 hgbot Checkin
2018-10-16 16:24 hgbot Note Added: 0107341
2018-10-16 16:24 hgbot Status scheduled => resolved
2018-10-16 16:24 hgbot Resolution open => fixed
2018-10-16 16:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/196db31bb02f702c89cbca0778f4f6edd04f1684 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core/rev/9c6008e24116a27620858cf38fb818f5401de608 [^]
2018-10-16 16:24 hgbot Checkin
2018-10-16 16:24 hgbot Note Added: 0107342
2018-10-16 16:24 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core/rev/9c6008e24116a27620858cf38fb818f5401de608 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal/rev/1198e2c11bb4cba53468763f73d5fcb53a42576c [^]
2018-10-18 13:05 marvintm Status resolved => closed
2018-10-18 13:05 marvintm Fixed in Version => RR18Q3.2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker