Openbravo Issue Tracking System - Retail Modules | ||||||||||||
| View Issue Details | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
| 0039428 | Retail Modules | Web POS | public | 2018-07-20 12:46 | 2018-10-18 13:05 | |||||||
| Reporter | migueldejuana | |||||||||||
| Assigned To | migueldejuana | |||||||||||
| Priority | normal | Severity | minor | Reproducibility | always | |||||||
| Status | closed | Resolution | fixed | |||||||||
| Platform | OS | 5 | OS Version | |||||||||
| Product Version | ||||||||||||
| Target Version | RR18Q3.2 | Fixed in Version | RR18Q3.2 | |||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | marvintm | |||||||||||
| OBNetwork customer | ||||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0039428: Do not set terminalName with empty value | |||||||||||
| Description | Since we added localStorage API, we save items in localStorage with the appName as prefix (WEBPOS.terminalName). There is a case where we try to getItem but appName is not yet defined in OB.MobileApp.model, so we cannot get it from localStorage and we get null value. | |||||||||||
| Steps To Reproduce | Put a breakpoint in login-model.js in the line: me.setTerminalName(OB.UTIL.localStorage.getItem('terminalAuthentication', me.get('appName')) === 'Y' ? OB.UTIL.localStorage.getItem('terminalName', me.get('appName')) : OB.UTIL.getParameterByName("terminal")); just before the line: OB.UTIL.HookManager.registerHook('OBMOBC_InitActions', function (args, c) { Load web Pos and see that: - OB.MobileApp.model is undefined so we cannot get the appName - OB.UTIL.localStorage.getItem('terminalAuthentication') is null - OB.UTIL.localStorage.getItem('terminalName') | |||||||||||
| Proposed Solution | Change the localStorage API adding the ability pass the appName. After this fix, we will be able to load items from localStorage before appName is defined in OB.MobileApp.model. Example: me.setTerminalName(OB.UTIL.localStorage.getItem('terminalAuthentication', me.get('appName')) === 'Y' ? OB.UTIL.localStorage.getItem('terminalName', me.get('appName')) : OB.UTIL.getParameterByName("terminal")); | |||||||||||
| Additional Information | ||||||||||||
| Tags | No tags attached. | |||||||||||
| Relationships |
| |||||||||||
| Attached Files | ||||||||||||
| Issue History | ||||||||||||
| Date Modified | Username | Field | Change | |||||||||
| 2018-10-09 19:03 | marvintm | Type | defect => backport | |||||||||
| 2018-10-09 19:03 | marvintm | Target Version | => RR18Q3.2 | |||||||||
| 2018-10-16 16:24 | hgbot | Checkin | ||||||||||
| 2018-10-16 16:24 | hgbot | Note Added: 0107341 | ||||||||||
| 2018-10-16 16:24 | hgbot | Status | scheduled => resolved | |||||||||
| 2018-10-16 16:24 | hgbot | Resolution | open => fixed | |||||||||
| 2018-10-16 16:24 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/196db31bb02f702c89cbca0778f4f6edd04f1684 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core/rev/9c6008e24116a27620858cf38fb818f5401de608 [^] | |||||||||
| 2018-10-16 16:24 | hgbot | Checkin | ||||||||||
| 2018-10-16 16:24 | hgbot | Note Added: 0107342 | ||||||||||
| 2018-10-16 16:24 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.mobile.core/rev/9c6008e24116a27620858cf38fb818f5401de608 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.2/org.openbravo.retail.posterminal/rev/1198e2c11bb4cba53468763f73d5fcb53a42576c [^] | |||||||||
| 2018-10-18 13:05 | marvintm | Status | resolved => closed | |||||||||
| 2018-10-18 13:05 | marvintm | Fixed in Version | => RR18Q3.2 | |||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||