Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039342
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 09. Financial managementmajoralways2018-09-13 20:272018-10-16 08:37
ReporterAtulOpenbravoView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2.3
StatusclosedFix in branchFixed in SCM revision00ab9e6f086f
ProjectionnoneETAnoneTarget Version3.0PR18Q2.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2014-04-03
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f7078a85289e6c61918f567b28d2df3fe17ddb47 [^]
Triggers an Emergency PackNo
Summary

0039342: Business Partner current balance is wrongly updated when using Reconciliation

DescriptionBusiness Partner current balance is wrongly updated when using Reconciliation
Steps To ReproduceTest Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner now it is set as -200.

This is not correct.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0039290 closedAtulOpenbravo Business Partner current balance is wrongly updated when using Reconciliation 

-  Notes
(0106979)
AtulOpenbravo (developer)
2018-09-25 05:59

Test Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner it is as it is -100.
(0106982)
AtulOpenbravo (developer)
2018-09-25 06:08
edited on: 2018-09-25 06:21

Test Plan

- Login as F&B International Group Admin
- Go to Financial Account and select Bank - Account 1
- Navigate to Payment Method: Wire Transfer
  Uncheck Automatic Deposit and Automatic Withdrawn Go to Sales Invoice
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.

(0107101)
AtulOpenbravo (developer)
2018-10-02 06:30

Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Deposited Not Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Withdrawan Not Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- Reactivate previous financial Account Transaction.
- Check business partner balance is set as 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0107102)
AtulOpenbravo (developer)
2018-10-02 06:30

Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Received,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Made
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0107103)
AtulOpenbravo (developer)
2018-10-02 06:30

Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Check that Payment Complete flag in previous Sales Invoice is set as Yes.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 15.
- Check that Payment Complete flag in previous Sales Invoice is set as No.

Similar test plan executed for purchase flow.
(0107309)
hgbot (developer)
2018-10-16 08:32

Repository: erp/backports/3.0PR18Q2.3
Changeset: 00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Sep 25 00:35:58 2018 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2.3/rev/00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24 [^]

Fixes Issue 39342: Business Partner current balance is wrongly
updated when using Reconciliation

** In case of prepayment invoice paid should be kept as false
in PaidStatusEventHandler.

---
M src/org/openbravo/event/PaidStatusEventHandler.java
---
(0107310)
Sandrahuguet (developer)
2018-10-16 08:37

Code review + testing OK

- Issue History
Date Modified Username Field Change
2018-09-24 11:58 AtulOpenbravo Type defect => backport
2018-09-24 11:58 AtulOpenbravo Target Version => 3.0PR18Q2.3
2018-09-25 05:59 AtulOpenbravo Note Added: 0106979
2018-09-25 06:08 AtulOpenbravo Note Added: 0106982
2018-09-25 06:21 AtulOpenbravo Note Edited: 0106982 View Revisions
2018-10-02 06:30 AtulOpenbravo Note Added: 0107101
2018-10-02 06:30 AtulOpenbravo Note Added: 0107102
2018-10-02 06:30 AtulOpenbravo Note Added: 0107103
2018-10-16 08:32 hgbot Checkin
2018-10-16 08:32 hgbot Note Added: 0107309
2018-10-16 08:32 hgbot Status scheduled => resolved
2018-10-16 08:32 hgbot Resolution open => fixed
2018-10-16 08:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q2.3/rev/00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24 [^]
2018-10-16 08:37 Sandrahuguet Review Assigned To => Sandrahuguet
2018-10-16 08:37 Sandrahuguet Note Added: 0107310
2018-10-16 08:37 Sandrahuguet Status resolved => closed
2018-10-16 08:37 Sandrahuguet Fixed in Version => 3.0PR18Q2.3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker