Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0039342Openbravo ERP09. Financial managementpublic2018-09-13 20:272018-10-16 08:37
AtulOpenbravo 
AtulOpenbravo 
normalmajoralways
closedfixed 
5
 
3.0PR18Q2.33.0PR18Q2.3 
Sandrahuguet
Core
Production - Confirmed Stable
2014-04-03
3.0PR14Q2
https://code.openbravo.com/erp/devel/pi/rev/f7078a85289e6c61918f567b28d2df3fe17ddb47 [^]
No
0039342: Business Partner current balance is wrongly updated when using Reconciliation
Business Partner current balance is wrongly updated when using Reconciliation
Test Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner now it is set as -200.

This is not correct.
No tags attached.
blocks defect 0039290 closed AtulOpenbravo Business Partner current balance is wrongly updated when using Reconciliation 
Issue History
2018-09-24 11:58AtulOpenbravoTypedefect => backport
2018-09-24 11:58AtulOpenbravoTarget Version => 3.0PR18Q2.3
2018-09-25 05:59AtulOpenbravoNote Added: 0106979
2018-09-25 06:08AtulOpenbravoNote Added: 0106982
2018-09-25 06:21AtulOpenbravoNote Edited: 0106982bug_revision_view_page.php?bugnote_id=0106982#r17673
2018-10-02 06:30AtulOpenbravoNote Added: 0107101
2018-10-02 06:30AtulOpenbravoNote Added: 0107102
2018-10-02 06:30AtulOpenbravoNote Added: 0107103
2018-10-16 08:32hgbotCheckin
2018-10-16 08:32hgbotNote Added: 0107309
2018-10-16 08:32hgbotStatusscheduled => resolved
2018-10-16 08:32hgbotResolutionopen => fixed
2018-10-16 08:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q2.3/rev/00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24 [^]
2018-10-16 08:37SandrahuguetReview Assigned To => Sandrahuguet
2018-10-16 08:37SandrahuguetNote Added: 0107310
2018-10-16 08:37SandrahuguetStatusresolved => closed
2018-10-16 08:37SandrahuguetFixed in Version => 3.0PR18Q2.3

Notes
(0106979)
AtulOpenbravo   
2018-09-25 05:59   
Test Plan

   - Login as F&B International Group admin role
   - Create a new Business Partner in F&B International Group
   - Create a Payment In for F&B España, S.A. and that business partner
   - Add an amount 100 and do not select any document to be paid. Leave the amount as credit
   - Check the payment has been deposited in a financial account.
   - Check that business partner current balance is set as -100.
   
  - Go to Financial Account where the payment was deposited.
  - Either leave the Matching Algorithm empty or keep it as Standard
  - Click on Reconcile or Match Statement button
  - Select the previously created payment or match the previous payment with similar record in bank statement.
  - Again check the current balance of business partner it is as it is -100.
(0106982)
AtulOpenbravo   
2018-09-25 06:08   
(edited on: 2018-09-25 06:21)
Test Plan

- Login as F&B International Group Admin
- Go to Financial Account and select Bank - Account 1
- Navigate to Payment Method: Wire Transfer
  Uncheck Automatic Deposit and Automatic Withdrawn Go to Sales Invoice
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.

(0107101)
AtulOpenbravo   
2018-10-02 06:30   
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Deposited Not Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Withdrawan Not Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- Reactivate previous financial Account Transaction.
- Check business partner balance is set as 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- Check Payment Complete in previous Sales Invoice header is set as Yes.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0107102)
AtulOpenbravo   
2018-10-02 06:30   
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Received,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Made
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10
   Product: Orange Juice bio, Quantity: 5
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is Yes.
- Check business partner balance is set as 0.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 0.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 0.

Similar test plan executed for purchase flow.
(0107103)
AtulOpenbravo   
2018-10-02 06:30   
Test Plan

- Login as F&B International Group Admin
- Create a preference "Allow to use invoice paid status control" with value = Yes
- Logout and Login
- Create a new financial account "39290 Financial Account", currency = USD,
   create a payment method for "Wire Transfer",
   set Invoice Paid Status = Payment Cleared,
   Automatic Deposit = No in Payment In section.
- In Payment Out, set Automatic Withdrawn = No, Invoice Paid Status = Payment Cleared
- Create a new business partner "39290 business partner"
  and its location in organization "F&B Us Inc",
  set Payment Method = "Wire Transfer".
- Go to sales Invoice and create a new invoice with this values:
   Organization: F&B US, Inc.
   Bussiness Partner: Healthy Food Supermarkets, Co.
   Payment Method: Wire Transfer
- Create new 2 lines:
   Product: Lemonade, Quantity: 10, Tax = Exempt
   Product: Orange Juice bio, Quantity: 5, Tax: Exempt
- Complete the invoice
- Check business partner balance is set as 15.
- Click in Add Payment button,
- Make sure that actual payment is 15 and click process
- Action regarding document: Process Received Payment(s)
- Notice that Payment complete in sales invoice header is set as No.
- Check business partner balance is set as 15.
- In Financial Account "39290 Financial Account", add transaction and select
  previous payment in.
- Process Financial Account Transaction.
- Check business partner balance is 15.
- Check Payment Complete in previous Sales Invoice header is set as No.
- In Financial Account "39290 Financial Account" make sure
  Matching Algorithm is set as blank.
- Click on Reconcile.
- Select previous payment in and set ending balance as 15, Save record.
- Check business partner balance is 0.
- Check that Payment Complete flag in previous Sales Invoice is set as Yes.
- Click on Reconcile: Uncheck previous payment in, set ending balance = 0, Save record.
- Check business partner balance is 15.
- Check that Payment Complete flag in previous Sales Invoice is set as No.

Similar test plan executed for purchase flow.
(0107309)
hgbot   
2018-10-16 08:32   
Repository: erp/backports/3.0PR18Q2.3
Changeset: 00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Sep 25 00:35:58 2018 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2.3/rev/00ab9e6f086faac14f2f9d2a51f9b9add4f2ec24 [^]

Fixes Issue 39342: Business Partner current balance is wrongly
updated when using Reconciliation

** In case of prepayment invoice paid should be kept as false
in PaidStatusEventHandler.

---
M src/org/openbravo/event/PaidStatusEventHandler.java
---
(0107310)
Sandrahuguet   
2018-10-16 08:37   
Code review + testing OK