Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039266
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajorhave not tried2018-09-11 16:232018-12-13 11:57
ReportercaristuView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039266: Review "loaded" check feature in CustomerLoader

DescriptionCurrently if the "loaded" property is not provided to the CustomerLoader, a NPE is raised:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/5dc356116798/src/org/openbravo/retail/posterminal/CustomerLoader.java#l72 [^]
Steps To ReproduceIn description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0039436RR19Q1 closedjorge-garcia Review "loaded" check feature in CustomerAddrLoader 

-  Notes
(0107205)
hgbot (developer)
2018-10-08 08:49

 Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: b41355ddcd9bdb7e7bc9b71a88b4dfb994845627
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 03 16:57:34 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/b41355ddcd9bdb7e7bc9b71a88b4dfb994845627 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

It's not necessary to change loaded or timezoneoffset values in contact info
for product to indicate a change had happened in customer model.

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---
(0107209)
hgbot (developer)
2018-10-08 11:04

 Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: fb49754d4c19679c6e23ee2d30cb136224f48741
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 08 11:04:08 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/fb49754d4c19679c6e23ee2d30cb136224f48741 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

Backed out changeset b41355ddcd9b

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---
(0107235)
hgbot (developer)
2018-10-11 08:31

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c75f3578e27113d256d7974cae9997253022a8a6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 09 17:39:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c75f3578e27113d256d7974cae9997253022a8a6 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

---
M src/org/openbravo/retail/posterminal/CustomerLoader.java
---
(0107246)
aferraz (viewer)
2018-10-11 10:33
edited on: 2018-10-11 11:24

 Same problem in CustomerAddrLoader (see 0039436):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/65a71ebd583a/src/org/openbravo/retail/posterminal/CustomerAddrLoader.java#l64 [^]
(0107781)
aferraz (viewer)
2018-11-07 15:15

 NPE is still raised in case user != null and userUpdated != null:

if ((loaded != null && loaded.compareTo(updated) < 0) || (user != null && userUpdated != null && (loaded.compareTo(userUpdated) < 0))) {
(0107840)
hgbot (developer)
2018-11-12 11:29

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3f94bf8e00522fee9918f74612feca8d2e58dafc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 07 16:34:57 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f94bf8e00522fee9918f74612feca8d2e58dafc [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

Fix problem when the user and the userupdate are not null but loaded is null.

---
M src/org/openbravo/retail/posterminal/CustomerLoader.java
---

- Issue History
Date Modified Username Field Change
2018-09-11 16:23 caristu New Issue
2018-09-11 16:23 caristu Assigned To => Retail
2018-09-11 16:23 caristu OBNetwork customer => No
2018-09-11 16:23 caristu Triggers an Emergency Pack => No
2018-09-11 16:24 caristu Description Updated View Revisions
2018-09-26 16:35 jorge-garcia Status new => scheduled
2018-09-26 16:35 jorge-garcia Assigned To Retail => jorge-garcia
2018-10-08 08:49 hgbot Checkin
2018-10-08 08:49 hgbot Note Added: 0107205
2018-10-08 11:04 hgbot Checkin
2018-10-08 11:04 hgbot Note Added: 0107209
2018-10-11 08:31 hgbot Checkin
2018-10-11 08:31 hgbot Note Added: 0107235
2018-10-11 10:33 aferraz Note Added: 0107246
2018-10-11 11:23 aferraz Issue cloned 0039436
2018-10-11 11:24 aferraz Relationship added related to 0039436
2018-10-11 11:24 aferraz Note Edited: 0107246 View Revisions
2018-10-11 11:27 aferraz Description Updated View Revisions
2018-10-11 11:28 jorge-garcia Status scheduled => resolved
2018-10-11 11:28 jorge-garcia Fixed in Version => RR19Q1
2018-10-11 11:28 jorge-garcia Resolution open => fixed
2018-10-29 11:32 marvintm Review Assigned To => marvintm
2018-10-29 11:32 marvintm Status resolved => closed
2018-11-07 15:15 aferraz Note Added: 0107781
2018-11-07 15:15 aferraz Status closed => new
2018-11-07 15:15 aferraz Resolution fixed => open
2018-11-07 15:15 aferraz Fixed in Version RR19Q1 =>
2018-11-07 16:31 jorge-garcia Status new => scheduled
2018-11-12 11:29 hgbot Checkin
2018-11-12 11:29 hgbot Note Added: 0107840
2018-11-12 11:30 jorge-garcia Status scheduled => resolved
2018-11-12 11:30 jorge-garcia Resolution open => fixed
2018-12-13 11:57 marvintm Status resolved => closed
2018-12-13 11:57 marvintm Fixed in Version => RR19Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker