Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039266Retail ModulesWeb POSpublic2018-09-11 16:232018-12-13 11:57
Reportercaristu 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039266: Review "loaded" check feature in CustomerLoader
DescriptionCurrently if the "loaded" property is not provided to the CustomerLoader, a NPE is raised:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/5dc356116798/src/org/openbravo/retail/posterminal/CustomerLoader.java#l72 [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0039436RR19Q1 closed jorge-garcia Review "loaded" check feature in CustomerAddrLoader 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-11 16:23caristuNew Issue
2018-09-11 16:23caristuAssigned To => Retail
2018-09-11 16:23caristuOBNetwork customer => No
2018-09-11 16:23caristuTriggers an Emergency Pack => No
2018-09-11 16:24caristuDescription Updatedbug_revision_view_page.php?rev_id=17617#r17617
2018-09-26 16:35jorge-garciaStatusnew => scheduled
2018-09-26 16:35jorge-garciaAssigned ToRetail => jorge-garcia
2018-10-08 08:49hgbotCheckin
2018-10-08 08:49hgbotNote Added: 0107205
2018-10-08 11:04hgbotCheckin
2018-10-08 11:04hgbotNote Added: 0107209
2018-10-11 08:31hgbotCheckin
2018-10-11 08:31hgbotNote Added: 0107235
2018-10-11 10:33aferrazNote Added: 0107246
2018-10-11 11:23aferrazIssue cloned0039436
2018-10-11 11:24aferrazRelationship addedrelated to 0039436
2018-10-11 11:24aferrazNote Edited: 0107246bug_revision_view_page.php?bugnote_id=0107246#r17753
2018-10-11 11:27aferrazDescription Updatedbug_revision_view_page.php?rev_id=17756#r17756
2018-10-11 11:28jorge-garciaStatusscheduled => resolved
2018-10-11 11:28jorge-garciaFixed in Version => RR19Q1
2018-10-11 11:28jorge-garciaResolutionopen => fixed
2018-10-29 11:32marvintmReview Assigned To => marvintm
2018-10-29 11:32marvintmStatusresolved => closed
2018-11-07 15:15aferrazNote Added: 0107781
2018-11-07 15:15aferrazStatusclosed => new
2018-11-07 15:15aferrazResolutionfixed => open
2018-11-07 15:15aferrazFixed in VersionRR19Q1 =>
2018-11-07 16:31jorge-garciaStatusnew => scheduled
2018-11-12 11:29hgbotCheckin
2018-11-12 11:29hgbotNote Added: 0107840
2018-11-12 11:30jorge-garciaStatusscheduled => resolved
2018-11-12 11:30jorge-garciaResolutionopen => fixed
2018-12-13 11:57marvintmStatusresolved => closed
2018-12-13 11:57marvintmFixed in Version => RR19Q1

Notes
(0107205)
hgbot   
2018-10-08 08:49   
Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: b41355ddcd9bdb7e7bc9b71a88b4dfb994845627
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 03 16:57:34 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/b41355ddcd9bdb7e7bc9b71a88b4dfb994845627 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

It's not necessary to change loaded or timezoneoffset values in contact info
for product to indicate a change had happened in customer model.

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---
(0107209)
hgbot   
2018-10-08 11:04   
Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: fb49754d4c19679c6e23ee2d30cb136224f48741
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 08 11:04:08 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/fb49754d4c19679c6e23ee2d30cb136224f48741 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

Backed out changeset b41355ddcd9b

---
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
---
(0107235)
hgbot   
2018-10-11 08:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c75f3578e27113d256d7974cae9997253022a8a6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 09 17:39:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c75f3578e27113d256d7974cae9997253022a8a6 [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

---
M src/org/openbravo/retail/posterminal/CustomerLoader.java
---
(0107246)
aferraz   
2018-10-11 10:33   
(edited on: 2018-10-11 11:24)
Same problem in CustomerAddrLoader (see 0039436):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/65a71ebd583a/src/org/openbravo/retail/posterminal/CustomerAddrLoader.java#l64 [^]
(0107781)
aferraz   
2018-11-07 15:15   
NPE is still raised in case user != null and userUpdated != null:

if ((loaded != null && loaded.compareTo(updated) < 0) || (user != null && userUpdated != null && (loaded.compareTo(userUpdated) < 0))) {
(0107840)
hgbot   
2018-11-12 11:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3f94bf8e00522fee9918f74612feca8d2e58dafc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 07 16:34:57 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f94bf8e00522fee9918f74612feca8d2e58dafc [^]

Related to issue 39266: Review "loaded" check feature in CustomerLoader

Fix problem when the user and the userupdate are not null but loaded is null.

---
M src/org/openbravo/retail/posterminal/CustomerLoader.java
---