Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039236
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2018-09-06 11:462018-12-04 14:17
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revision405b5ad065bf
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039236: payment method has been deactivated when there is a cashup open, and sales were done in this payment method

DescriptionCurrently it's possible to disable a payment method for a Terminal, even if there is currently a cashup open, and sales were done for this payment method.

This will then lead to problems when trying to process the cashup.
Steps To Reproduce[POS]
. login
. do sales withi payment method "cash"

[BO]
. deactivate payment method "Cash" of this terminal

[POS]
- refresh web pos, and then do cashup
- notice the cashup went to errors while importing
Proposed SolutionIt should not be possible to disable the payment method of a terminal, if the terminal has an open cashup, and contains sales for this payment method.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039233 closedranjith_qualiantech_com Add new initial validations during the login 
depends on backport 0039746RR18Q4.1 closedranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 
depends on backport 0039747RR18Q3.4 closedranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 

-  Notes
(0107714)
hgbot (developer)
2018-11-02 06:58

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8cedcb8b18221f28e5dda1296f8e20a0e53339a7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Nov 02 11:27:54 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^]

Fixed issue 39236 : Added Initial Validtion to check inactive payment have receipt payments

* Added Initial Validtion for terminal payment type, if receipt is pending for cashup and receipts payment is inactive

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0107729)
hgbot (developer)
2018-11-05 09:46

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7f45d30a8ad367cb4e50d06bb95ef5dfc58dc530
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 05 09:46:36 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7f45d30a8ad367cb4e50d06bb95ef5dfc58dc530 [^]

Related to issue 39236 : Added Initial Validation to check inactive payment
have receipt payments

Backout changeset 8cedcb8b1822.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0107925)
hgbot (developer)
2018-11-15 10:17

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 405b5ad065bf619565c26ec73d45eaf4d8bf34b8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 15 14:47:14 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/405b5ad065bf619565c26ec73d45eaf4d8bf34b8 [^]

Fixed issue 39236 : Added Event Handler for Payment Method to check cashup is processed

* Added Event Handler for payment method while deactivating or removing it.
* Payment method can be deactivated or removed only when Cashup should be processed for all terminals

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java
---
(0107926)
hgbot (developer)
2018-11-15 10:17

 Repository: tools/automation/pi-mobile
Changeset: b624fc64ab891ba37a23e81842c6c95b429b93d8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 15 14:47:23 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b624fc64ab891ba37a23e81842c6c95b429b93d8 [^]

Verifies issue 39236 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---

- Issue History
Date Modified Username Field Change
2018-09-06 11:46 malsasua New Issue
2018-09-06 11:46 malsasua Assigned To => Retail
2018-09-06 11:46 malsasua Triggers an Emergency Pack => No
2018-09-06 11:46 malsasua Relationship added related to 0039233
2018-09-06 14:01 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-09-06 19:15 malsasua Resolution time => 1551826800
2018-09-10 16:04 ranjith_qualiantech_com Status new => scheduled
2018-10-29 13:02 marvintm Summary Initial Validation: payment method has been deactivated => payment method has been deactivated when there is a cashup open, and sales were done in this payment method
2018-10-29 13:02 marvintm Description Updated View Revisions
2018-10-29 13:02 marvintm Steps to Reproduce Updated View Revisions
2018-10-29 13:02 marvintm Proposed Solution updated
2018-11-02 06:58 hgbot Checkin
2018-11-02 06:58 hgbot Note Added: 0107714
2018-11-02 06:58 hgbot Status scheduled => resolved
2018-11-02 06:58 hgbot Resolution open => fixed
2018-11-02 06:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^]
2018-11-05 09:46 hgbot Checkin
2018-11-05 09:46 hgbot Note Added: 0107729
2018-11-05 10:04 jorge-garcia Status resolved => new
2018-11-05 10:04 jorge-garcia Resolution fixed => open
2018-11-07 02:36 ranjith_qualiantech_com Status new => scheduled
2018-11-15 10:17 hgbot Checkin
2018-11-15 10:17 hgbot Note Added: 0107925
2018-11-15 10:17 hgbot Status scheduled => resolved
2018-11-15 10:17 hgbot Resolution open => fixed
2018-11-15 10:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/405b5ad065bf619565c26ec73d45eaf4d8bf34b8 [^]
2018-11-15 10:17 hgbot Checkin
2018-11-15 10:17 hgbot Note Added: 0107926
2018-12-04 12:57 marvintm Status resolved => new
2018-12-04 12:57 marvintm Resolution fixed => open
2018-12-04 12:57 marvintm Status new => scheduled
2018-12-04 12:57 marvintm Status scheduled => resolved
2018-12-04 12:57 marvintm Fixed in Version => RR19Q1
2018-12-04 12:57 marvintm Resolution open => fixed
2018-12-04 14:17 marvintm Review Assigned To => marvintm
2018-12-04 14:17 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker