Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039236Retail ModulesWeb POSpublic2018-09-06 11:462018-12-04 14:17
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039236: payment method has been deactivated when there is a cashup open, and sales were done in this payment method
DescriptionCurrently it's possible to disable a payment method for a Terminal, even if there is currently a cashup open, and sales were done for this payment method.

This will then lead to problems when trying to process the cashup.
Steps To Reproduce[POS]
. login
. do sales withi payment method "cash"

[BO]
. deactivate payment method "Cash" of this terminal

[POS]
- refresh web pos, and then do cashup
- notice the cashup went to errors while importing
Proposed SolutionIt should not be possible to disable the payment method of a terminal, if the terminal has an open cashup, and contains sales for this payment method.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039233 closed ranjith_qualiantech_com Add new initial validations during the login 
depends on backport 0039746RR18Q4.1 closed ranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 
depends on backport 0039747RR18Q3.4 closed ranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-09-06 11:46malsasuaNew Issue
2018-09-06 11:46malsasuaAssigned To => Retail
2018-09-06 11:46malsasuaOBNetwork customer => Yes
2018-09-06 11:46malsasuaTriggers an Emergency Pack => No
2018-09-06 11:46malsasuaRelationship addedrelated to 0039233
2018-09-06 14:01ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-09-06 19:15malsasuaResolution time => 1551826800
2018-09-10 16:04ranjith_qualiantech_comStatusnew => scheduled
2018-10-29 13:02marvintmSummaryInitial Validation: payment method has been deactivated => payment method has been deactivated when there is a cashup open, and sales were done in this payment method
2018-10-29 13:02marvintmDescription Updatedbug_revision_view_page.php?rev_id=17879#r17879
2018-10-29 13:02marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17881#r17881
2018-10-29 13:02marvintmProposed Solution updated
2018-11-02 06:58hgbotCheckin
2018-11-02 06:58hgbotNote Added: 0107714
2018-11-02 06:58hgbotStatusscheduled => resolved
2018-11-02 06:58hgbotResolutionopen => fixed
2018-11-02 06:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^]
2018-11-05 09:46hgbotCheckin
2018-11-05 09:46hgbotNote Added: 0107729
2018-11-05 10:04jorge-garciaStatusresolved => new
2018-11-05 10:04jorge-garciaResolutionfixed => open
2018-11-07 02:36ranjith_qualiantech_comStatusnew => scheduled
2018-11-15 10:17hgbotCheckin
2018-11-15 10:17hgbotNote Added: 0107925
2018-11-15 10:17hgbotStatusscheduled => resolved
2018-11-15 10:17hgbotResolutionopen => fixed
2018-11-15 10:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/405b5ad065bf619565c26ec73d45eaf4d8bf34b8 [^]
2018-11-15 10:17hgbotCheckin
2018-11-15 10:17hgbotNote Added: 0107926
2018-12-04 12:57marvintmStatusresolved => new
2018-12-04 12:57marvintmResolutionfixed => open
2018-12-04 12:57marvintmStatusnew => scheduled
2018-12-04 12:57marvintmStatusscheduled => resolved
2018-12-04 12:57marvintmFixed in Version => RR19Q1
2018-12-04 12:57marvintmResolutionopen => fixed
2018-12-04 14:17marvintmReview Assigned To => marvintm
2018-12-04 14:17marvintmStatusresolved => closed

Notes
(0107714)
hgbot   
2018-11-02 06:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8cedcb8b18221f28e5dda1296f8e20a0e53339a7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Nov 02 11:27:54 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8cedcb8b18221f28e5dda1296f8e20a0e53339a7 [^]

Fixed issue 39236 : Added Initial Validtion to check inactive payment have receipt payments

* Added Initial Validtion for terminal payment type, if receipt is pending for cashup and receipts payment is inactive

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0107729)
hgbot   
2018-11-05 09:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7f45d30a8ad367cb4e50d06bb95ef5dfc58dc530
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 05 09:46:36 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7f45d30a8ad367cb4e50d06bb95ef5dfc58dc530 [^]

Related to issue 39236 : Added Initial Validation to check inactive payment
have receipt payments

Backout changeset 8cedcb8b1822.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0107925)
hgbot   
2018-11-15 10:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 405b5ad065bf619565c26ec73d45eaf4d8bf34b8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 15 14:47:14 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/405b5ad065bf619565c26ec73d45eaf4d8bf34b8 [^]

Fixed issue 39236 : Added Event Handler for Payment Method to check cashup is processed

* Added Event Handler for payment method while deactivating or removing it.
* Payment method can be deactivated or removed only when Cashup should be processed for all terminals

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java
---
(0107926)
hgbot   
2018-11-15 10:17   
Repository: tools/automation/pi-mobile
Changeset: b624fc64ab891ba37a23e81842c6c95b429b93d8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Nov 15 14:47:23 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b624fc64ab891ba37a23e81842c6c95b429b93d8 [^]

Verifies issue 39236 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---