Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039197
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-08-30 08:592018-09-24 09:33
ReporterumartirenaView Statuspublic 
Assigned Tomarvintm 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9bf67434b07d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression levelProduction - QA Approved
Regression date2018-04-23
Regression introduced in releaseRR18Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/819ac4a1f0fc [^]
Triggers an Emergency PackNo
Summary

0039197: "Get Product Tax Category impementation" preference wrong configuration makes not possible to add products in Web POS

DescriptionIf "Get Product Tax Category impementation" preference is configured as "N" and no module is installed to implement Multi Tax Category it will not be possible to add any product in Web POS. "Cannot calculate receipt taxes" error popup appears and the products are not added.
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_pi_pgsql [^] configure "Get Product Tax Category impementation" as value "N" for client white valley.

Login in https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1. [^]
Try to add any product to a ticket.
Check an error popup is displayed with message "Cannot calculate receipt taxes" and the product is not added
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0039199RR18Q3.2 closedRetail "Get Product Tax Category impementation" preference wrong configuration makes not possible to add products in Web POS 

-  Notes
(0106533)
hgbot (developer)
2018-08-30 10:24

 Repository: erp/pmods/org.openbravo.retail.multitaxcategory
Changeset: 8fd9ecac5f47ff007203922a9fe76952b473d67a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Aug 30 10:24:05 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^]

Fixed issue 39197. 'Get Product Tax Category impementation' preference wrong configuration makes not possible to add products in Web POS
Two changes have been made:
- Added a priority to the taxCategory property to ensure that multitax version prevails always if present
- Do not read anymore the value of the preference GETPRODUCTTAXCATEGORY, as it is no longer used. Now the Core version of the taxCategory property will always be added, and later on replaced if there is another version with higher priority.

---
M src/org/openbravo/retail/multitaxcategory/master/TaxCategoryProductProperties.java
---
(0106534)
hgbot (developer)
2018-08-30 10:24

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9bf67434b07d8a174b4f6fea79ef38f0bdefc045
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Aug 30 10:24:20 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bf67434b07d8a174b4f6fea79ef38f0bdefc045 [^]

Fixed issue 39197. 'Get Product Tax Category impementation' preference wrong configuration makes not possible to add products in Web POS
Two changes have been made:
- Added a priority to the taxCategory property to ensure that multitax version prevails always if present
- Do not read anymore the value of the preference GETPRODUCTTAXCATEGORY, as it is no longer used. Now the Core version of the taxCategory property will always be added, and later on replaced if there is another version with higher priority.

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0106571)
hgbot (developer)
2018-08-31 14:01

 Repository: erp/pmods/org.openbravo.retail.multitaxcategory
Changeset: ec61aa23ffe95b9a7a8cceddd951cbe41f6b31c7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Aug 31 14:01:04 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/ec61aa23ffe95b9a7a8cceddd951cbe41f6b31c7 [^]

Related to issue 39197. Added priority also for taxCategory property defined for the LoadedProduct functionality

---
M src/org/openbravo/retail/multitaxcategory/master/TaxCategoryLoadedProductProperties.java
---
(0106946)
migueldejuana (developer)
2018-09-24 09:33

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2018-08-30 08:59 umartirena New Issue
2018-08-30 08:59 umartirena Assigned To => Retail
2018-08-30 08:59 umartirena Regression level => Production - QA Approved
2018-08-30 08:59 umartirena Regression date => 2018-04-23
2018-08-30 08:59 umartirena Regression introduced in release => RR18Q3
2018-08-30 08:59 umartirena Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/819ac4a1f0fc [^]
2018-08-30 08:59 umartirena Triggers an Emergency Pack => No
2018-08-30 09:53 marvintm Status new => scheduled
2018-08-30 09:53 marvintm Assigned To Retail => marvintm
2018-08-30 10:24 hgbot Checkin
2018-08-30 10:24 hgbot Note Added: 0106533
2018-08-30 10:24 hgbot Status scheduled => resolved
2018-08-30 10:24 hgbot Resolution open => fixed
2018-08-30 10:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^]
2018-08-30 10:24 hgbot Checkin
2018-08-30 10:24 hgbot Note Added: 0106534
2018-08-30 10:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bf67434b07d8a174b4f6fea79ef38f0bdefc045 [^]
2018-08-30 11:50 martinsdan Issue Monitored: martinsdan
2018-08-31 14:01 hgbot Checkin
2018-08-31 14:01 hgbot Note Added: 0106571
2018-09-12 16:56 marvintm Review Assigned To => migueldejuana
2018-09-24 09:33 migueldejuana Note Added: 0106946
2018-09-24 09:33 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker