Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039197Retail ModulesWeb POSpublic2018-08-30 08:592018-09-24 09:33
Reporterumartirena 
Assigned Tomarvintm 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2018-04-23
Regression introduced in releaseRR18Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/819ac4a1f0fc [^]
Triggers an Emergency PackNo
Summary0039197: "Get Product Tax Category impementation" preference wrong configuration makes not possible to add products in Web POS
DescriptionIf "Get Product Tax Category impementation" preference is configured as "N" and no module is installed to implement Multi Tax Category it will not be possible to add any product in Web POS. "Cannot calculate receipt taxes" error popup appears and the products are not added.
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_pi_pgsql [^] configure "Get Product Tax Category impementation" as value "N" for client white valley.

Login in https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1. [^]
Try to add any product to a ticket.
Check an error popup is displayed with message "Cannot calculate receipt taxes" and the product is not added
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0039199RR18Q3.2 closed Retail "Get Product Tax Category impementation" preference wrong configuration makes not possible to add products in Web POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-30 08:59umartirenaNew Issue
2018-08-30 08:59umartirenaAssigned To => Retail
2018-08-30 08:59umartirenaRegression level => Production - QA Approved
2018-08-30 08:59umartirenaRegression date => 2018-04-23
2018-08-30 08:59umartirenaRegression introduced in release => RR18Q3
2018-08-30 08:59umartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/819ac4a1f0fc [^]
2018-08-30 08:59umartirenaTriggers an Emergency Pack => No
2018-08-30 09:53marvintmStatusnew => scheduled
2018-08-30 09:53marvintmAssigned ToRetail => marvintm
2018-08-30 10:24hgbotCheckin
2018-08-30 10:24hgbotNote Added: 0106533
2018-08-30 10:24hgbotStatusscheduled => resolved
2018-08-30 10:24hgbotResolutionopen => fixed
2018-08-30 10:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^]
2018-08-30 10:24hgbotCheckin
2018-08-30 10:24hgbotNote Added: 0106534
2018-08-30 10:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bf67434b07d8a174b4f6fea79ef38f0bdefc045 [^]
2018-08-30 11:50martinsdanIssue Monitored: martinsdan
2018-08-31 14:01hgbotCheckin
2018-08-31 14:01hgbotNote Added: 0106571
2018-09-12 16:56marvintmReview Assigned To => migueldejuana
2018-09-24 09:33migueldejuanaNote Added: 0106946
2018-09-24 09:33migueldejuanaStatusresolved => closed

Notes
(0106533)
hgbot   
2018-08-30 10:24   
Repository: erp/pmods/org.openbravo.retail.multitaxcategory
Changeset: 8fd9ecac5f47ff007203922a9fe76952b473d67a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Aug 30 10:24:05 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/8fd9ecac5f47ff007203922a9fe76952b473d67a [^]

Fixed issue 39197. 'Get Product Tax Category impementation' preference wrong configuration makes not possible to add products in Web POS
Two changes have been made:
- Added a priority to the taxCategory property to ensure that multitax version prevails always if present
- Do not read anymore the value of the preference GETPRODUCTTAXCATEGORY, as it is no longer used. Now the Core version of the taxCategory property will always be added, and later on replaced if there is another version with higher priority.

---
M src/org/openbravo/retail/multitaxcategory/master/TaxCategoryProductProperties.java
---
(0106534)
hgbot   
2018-08-30 10:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9bf67434b07d8a174b4f6fea79ef38f0bdefc045
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Aug 30 10:24:20 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9bf67434b07d8a174b4f6fea79ef38f0bdefc045 [^]

Fixed issue 39197. 'Get Product Tax Category impementation' preference wrong configuration makes not possible to add products in Web POS
Two changes have been made:
- Added a priority to the taxCategory property to ensure that multitax version prevails always if present
- Do not read anymore the value of the preference GETPRODUCTTAXCATEGORY, as it is no longer used. Now the Core version of the taxCategory property will always be added, and later on replaced if there is another version with higher priority.

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0106571)
hgbot   
2018-08-31 14:01   
Repository: erp/pmods/org.openbravo.retail.multitaxcategory
Changeset: ec61aa23ffe95b9a7a8cceddd951cbe41f6b31c7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Aug 31 14:01:04 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multitaxcategory/rev/ec61aa23ffe95b9a7a8cceddd951cbe41f6b31c7 [^]

Related to issue 39197. Added priority also for taxCategory property defined for the LoadedProduct functionality

---
M src/org/openbravo/retail/multitaxcategory/master/TaxCategoryLoadedProductProperties.java
---
(0106946)
migueldejuana   
2018-09-24 09:33   
Tested and reviewed