Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039014
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-07-23 15:422018-08-08 13:06
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q4
StatusclosedFix in branchFixed in SCM revisionfc0c131d8cd0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039014: unneeded queries to count active alerts

DescriptionWhen counting active alerts for current session, a count query is executed per each Alert Rule current user is recipient for.
Steps To Reproduce1. Define 5 different Alert Rules
2. Assign them all to Openbravo user
3. Log in with Openbravo
  -> Check each time alert ping is performed, count for each rule is executed in DB
Proposed SolutionGroup rules by filter clause to do the count.
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039023 closedalostale unneeded contention to count active alerts 

-  Notes
(0105909)
hgbot (developer)
2018-07-24 12:29

 Repository: erp/devel/pi
Changeset: 328be6af97c0f9e28e247932ba5f94f920d00058
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 24 12:08:20 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/328be6af97c0f9e28e247932ba5f94f920d00058 [^]

related to bug 39014: code clean up

  extracted different actions to separate methods

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0105910)
hgbot (developer)
2018-07-24 12:29

 Repository: erp/devel/pi
Changeset: fc0c131d8cd02c903e874647f69e4314702c3341
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 24 12:13:23 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fc0c131d8cd02c903e874647f69e4314702c3341 [^]

fixed bug 39014: unneeded queries to ad_alert

  When counting active alerts, a count query was executed per each accesible
  alert rule. As part of the alert sql is dynamically generated based on rule's
  filter clase, it is only necessary to execute different queries per each
  different filter clause.

  Now alerts are grouped by fiter clause to execute the queries.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0105919)
hgbot (developer)
2018-07-24 16:11

 Repository: erp/devel/pi
Changeset: 79bbbb6e87d07e6724140d6e52299171f78233bb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 24 16:11:24 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/79bbbb6e87d07e6724140d6e52299171f78233bb [^]

related to bug 39014: fixed NPE

  When processing alert rules with null filter clause

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0106152)
caristu (viewer)
2018-08-03 10:32

 Code reviewed + tested OK.
(0106220)
hudsonbot (viewer)
2018-08-08 13:06

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test
(0106221)
hudsonbot (viewer)
2018-08-08 13:06

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test
(0106225)
hudsonbot (viewer)
2018-08-08 13:06

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-07-23 15:42 alostale New Issue
2018-07-23 15:42 alostale Assigned To => platform
2018-07-23 15:42 alostale OBNetwork customer => No
2018-07-23 15:42 alostale Modules => Core
2018-07-23 15:42 alostale Triggers an Emergency Pack => No
2018-07-23 15:55 alostale Proposed Solution updated
2018-07-23 15:55 alostale Assigned To platform => alostale
2018-07-24 12:22 alostale Review Assigned To => caristu
2018-07-24 12:22 alostale Proposed Solution updated
2018-07-24 12:23 alostale Tag Attached: Performance
2018-07-24 12:27 alostale Relationship added related to 0039023
2018-07-24 12:29 hgbot Checkin
2018-07-24 12:29 hgbot Note Added: 0105909
2018-07-24 12:29 hgbot Checkin
2018-07-24 12:29 hgbot Note Added: 0105910
2018-07-24 12:29 hgbot Status new => resolved
2018-07-24 12:29 hgbot Resolution open => fixed
2018-07-24 12:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fc0c131d8cd02c903e874647f69e4314702c3341 [^]
2018-07-24 16:11 hgbot Checkin
2018-07-24 16:11 hgbot Note Added: 0105919
2018-08-03 10:32 caristu Note Added: 0106152
2018-08-03 10:32 caristu Status resolved => closed
2018-08-03 10:32 caristu Fixed in Version => 3.0PR18Q4
2018-08-08 13:06 hudsonbot Checkin
2018-08-08 13:06 hudsonbot Note Added: 0106220
2018-08-08 13:06 hudsonbot Checkin
2018-08-08 13:06 hudsonbot Note Added: 0106221
2018-08-08 13:06 hudsonbot Checkin
2018-08-08 13:06 hudsonbot Note Added: 0106225

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker