Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039023
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-07-24 12:272018-08-08 13:06
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q4
StatusclosedFix in branchFixed in SCM revision3d151a1172b8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039023: unneeded contention to count active alerts

DescriptionEvery few seconds a request to AlertActionHandler is performed, it serves 2 purposes:

1. Update ad_session table with current timestamp to mark "session last seen"
2. Count active alerts

They are executed in that order in a single db transaction, in case counting alerts takes long, locks on ad_session table are hold until it completes.
Steps To Reproduce1. Define several alerts for a user, so that counting them takes some time
2. Check pg_locks while executing a AlertActionHandler request:
  -> It is kept till request is completed.
Proposed SolutionCommit ping transaction before starting counting alerts
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039014 closedalostale unneeded queries to count active alerts 

-  Notes
(0105911)
hgbot (developer)
2018-07-24 12:29

 Repository: erp/devel/pi
Changeset: 3d151a1172b8de6feecd545c45f6766cad190414
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 24 12:29:30 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d151a1172b8de6feecd545c45f6766cad190414 [^]

fixed bug 39023: unneeded contention to count active alerts

  Commit transaction after updating ad_session so that locks on ad_session are not
  hold while counting active alerts

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0106153)
caristu (viewer)
2018-08-03 10:35

 Code reviewed + tested OK.
(0106222)
hudsonbot (viewer)
2018-08-08 13:06

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-07-24 12:27 alostale New Issue
2018-07-24 12:27 alostale Assigned To => platform
2018-07-24 12:27 alostale OBNetwork customer => No
2018-07-24 12:27 alostale Modules => Core
2018-07-24 12:27 alostale Triggers an Emergency Pack => No
2018-07-24 12:27 alostale Tag Attached: Performance
2018-07-24 12:27 alostale Relationship added related to 0039014
2018-07-24 12:28 alostale Review Assigned To => caristu
2018-07-24 12:29 hgbot Checkin
2018-07-24 12:29 hgbot Note Added: 0105911
2018-07-24 12:29 hgbot Status new => resolved
2018-07-24 12:29 hgbot Resolution open => fixed
2018-07-24 12:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3d151a1172b8de6feecd545c45f6766cad190414 [^]
2018-08-03 10:34 caristu Assigned To platform => alostale
2018-08-03 10:35 caristu Note Added: 0106153
2018-08-03 10:35 caristu Status resolved => closed
2018-08-03 10:35 caristu Fixed in Version => 3.0PR18Q4
2018-08-08 13:06 hudsonbot Checkin
2018-08-08 13:06 hudsonbot Note Added: 0106222

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker