Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038988
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorhave not tried2018-07-18 23:292018-08-16 13:20
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision0b37902cb28e
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038988: When orderloader notices that an order exists and loaded timestamp not set then show relevant error message

DescriptionWhen for some reason a ticket is not removed from the UI on submit and is saved in the backend. At resubmit the logic will get to this code [1], which assumes that the loaded property is set in the jsonobject. If not then a technical error is shown.

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/OrderLoader.java#l265 [^]
Steps To ReproduceProbably easiest to install multi server
Run the CS in debug mode
Put a breakpoint here [1]
Submit a ticket from Webpos
The breakpoint is hit in CS, do step-over (so the commit happens)
Then stop CS
WebPOS/SS go offline
Restart CS
Replication from CS to SS happens, the ticket is now present in the SS
Login in WebPOS
Ticket is shown
Resubmit

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l195 [^]
Proposed SolutionInstead of showing technical error message, show the outdated data message
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2018-07-18 23-02-47.png [^] (104,381 bytes) 2018-07-18 23:29


diff file icon t.diff [^] (962 bytes) 2018-07-25 10:34 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0105995)
hgbot (developer)
2018-07-30 09:52

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0b37902cb28e0f76f57c7be7a2efb6428dce18b1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jul 30 09:52:13 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b37902cb28e0f76f57c7be7a2efb6428dce18b1 [^]

Fixes issue 38988: When orderloader notices that an order exists and loaded timestamp not set then show relevant error message
When loaded is null then show correct error

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2018-07-18 23:29 mtaal New Issue
2018-07-18 23:29 mtaal Assigned To => mtaal
2018-07-18 23:29 mtaal File Added: Screenshot from 2018-07-18 23-02-47.png
2018-07-18 23:29 mtaal OBNetwork customer => No
2018-07-18 23:29 mtaal Triggers an Emergency Pack => No
2018-07-25 10:34 mtaal File Added: t.diff
2018-07-30 09:52 mtaal Review Assigned To => migueldejuana
2018-07-30 09:52 hgbot Checkin
2018-07-30 09:52 hgbot Note Added: 0105995
2018-07-30 09:52 hgbot Status new => resolved
2018-07-30 09:52 hgbot Resolution open => fixed
2018-07-30 09:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b37902cb28e0f76f57c7be7a2efb6428dce18b1 [^]
2018-08-16 13:20 marvintm Review Assigned To migueldejuana => marvintm
2018-08-16 13:20 marvintm Status resolved => closed
2018-08-16 13:20 marvintm Fixed in Version => RR18Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker