Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038988Retail ModulesWeb POSpublic2018-07-18 23:292018-08-16 13:20
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038988: When orderloader notices that an order exists and loaded timestamp not set then show relevant error message
DescriptionWhen for some reason a ticket is not removed from the UI on submit and is saved in the backend. At resubmit the logic will get to this code [1], which assumes that the loaded property is set in the jsonobject. If not then a technical error is shown.

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/OrderLoader.java#l265 [^]
Steps To ReproduceProbably easiest to install multi server
Run the CS in debug mode
Put a breakpoint here [1]
Submit a ticket from Webpos
The breakpoint is hit in CS, do step-over (so the commit happens)
Then stop CS
WebPOS/SS go offline
Restart CS
Replication from CS to SS happens, the ticket is now present in the SS
Login in WebPOS
Ticket is shown
Resubmit

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l195 [^]
Proposed SolutionInstead of showing technical error message, show the outdated data message
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2018-07-18 23-02-47.png (104,381) 2018-07-18 23:29
https://issues.openbravo.com/file_download.php?file_id=11976&type=bug
png

diff t.diff (962) 2018-07-25 10:34
https://issues.openbravo.com/file_download.php?file_id=12004&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-07-18 23:29mtaalNew Issue
2018-07-18 23:29mtaalAssigned To => mtaal
2018-07-18 23:29mtaalFile Added: Screenshot from 2018-07-18 23-02-47.png
2018-07-18 23:29mtaalOBNetwork customer => No
2018-07-18 23:29mtaalTriggers an Emergency Pack => No
2018-07-25 10:34mtaalFile Added: t.diff
2018-07-30 09:52mtaalReview Assigned To => migueldejuana
2018-07-30 09:52hgbotCheckin
2018-07-30 09:52hgbotNote Added: 0105995
2018-07-30 09:52hgbotStatusnew => resolved
2018-07-30 09:52hgbotResolutionopen => fixed
2018-07-30 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b37902cb28e0f76f57c7be7a2efb6428dce18b1 [^]
2018-08-16 13:20marvintmReview Assigned Tomigueldejuana => marvintm
2018-08-16 13:20marvintmStatusresolved => closed
2018-08-16 13:20marvintmFixed in Version => RR18Q4

Notes
(0105995)
hgbot   
2018-07-30 09:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0b37902cb28e0f76f57c7be7a2efb6428dce18b1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jul 30 09:52:13 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0b37902cb28e0f76f57c7be7a2efb6428dce18b1 [^]

Fixes issue 38988: When orderloader notices that an order exists and loaded timestamp not set then show relevant error message
When loaded is null then show correct error

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---