Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038750
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-06-13 13:232018-06-15 11:54
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision79ca02c60af2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038750: It is possible to generate overpayments in cash payment methods

DescriptionIt is possible to generate overpayments in cash payment methods.
When a layaway with a cash prepayment is loaded in web pos, and a second cash payment is added, if this second payment is greater that the pending amount, but lower than the total amount of the ticket, instead of generating change for the customer, an overpayment is generated.
Steps To ReproduceLogin in web pos.
Create a new Layaway (Menu > Layaway this receipt)
Add an avalanche transceiver (total: 150.50€)
Click on the Total Amount button to go to the payments tab
Add a 50€ payment in Cash
Click on Layaway to synchronize the ticket.
Go to the Menu > Open Receipts and load the layaway again.
Click on the Total Amount button to go to the payments tab.
Add a 110€ payment in Cash.
verify that the payment tab shows a "9.50€ overpayment." message instead of a "9.50€ remaining to return." message.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038333 closedranjith_qualiantech_com Wrong Payment Details created in backend when paying Layaway with Cash first then overpaying with Digital Coupon 
causes defect 0038904 closedranjith_qualiantech_com Change was not caluclated properly when payments exceeds pending amount 

-  Notes
(0105141)
hgbot (developer)
2018-06-14 12:52

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 250d589a586b180e0b7d5888fa13a2b138e9b570
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 14 16:22:25 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^]

Fixed issue 38750 : Change should not be calculated based on Prepayments

* If Cash payments (includes prepayment) is higher than Total Amount, then Extra Cash should be given as Change
* If Card payments (includes prepayment) is higher than Total Amount, then Extra Cash should be considred as Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105145)
hgbot (developer)
2018-06-14 15:58

 Repository: tools/automation/pi-mobile
Changeset: 43d7412fb7526de2b23a44dbc9c89fdae0d6bcb9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 14 16:22:44 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/43d7412fb7526de2b23a44dbc9c89fdae0d6bcb9 [^]

Verifies issue 38750 : Added automated test 'I38750_VerfiyCashChangeOnLayaway'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38750_VerfiyCashChangeOnLayaway.java
---
(0105147)
migueldejuana (developer)
2018-06-14 16:22

 Login in web pos.
Create a new Layaway (Menu > Layaway this receipt)
Add an avalanche transceiver (total: 150.50€)
Click on the Total Amount button to go to the payments tab
Add a 20€ payment in Cash
Click on Layaway to synchronize the ticket.
Go to the Menu > Open Receipts and load the layaway again.
Click on the Total Amount button to go to the payments tab.
Add a 20€ payment in Cash.
Add a 150$ payment in USA Cash.
verify that the payment tab shows a "3.62$ overpayment." message instead of a "3.62$ remaining to return." message.

Add a test with this case.
Play with payments and try to find another failing case
(0105169)
hgbot (developer)
2018-06-15 10:32

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 79ca02c60af2e3458de7db970271a2b681e5e90c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 15 14:01:58 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79ca02c60af2e3458de7db970271a2b681e5e90c [^]

Fixed issue 38750 : Change should not be calculated based on Prepayments

* If Cash payments (includes prepayment) is higher than Total Amount, then Extra Cash should be given as Change
* If Card payments (includes prepayment) is higher than Total Amount, then Extra Cash should be considred as Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105174)
hgbot (developer)
2018-06-15 11:01

 Repository: tools/automation/pi-mobile
Changeset: 94b31e322c0ac12276d5f69b04f93da3d78cd701
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 15 14:02:10 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/94b31e322c0ac12276d5f69b04f93da3d78cd701 [^]

Verifies issue 38750 : Modified automated test 'I38750_VerfiyCashChangeOnLayaway'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38750_VerfiyCashChangeOnLayaway.java
---
(0105178)
migueldejuana (developer)
2018-06-15 11:54

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2018-06-13 13:23 aaroncalero New Issue
2018-06-13 13:23 aaroncalero Assigned To => Retail
2018-06-13 13:23 aaroncalero Resolution time => 1530050400
2018-06-13 13:23 aaroncalero Triggers an Emergency Pack => No
2018-06-13 13:26 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-06-13 13:26 ranjith_qualiantech_com Status new => scheduled
2018-06-13 15:16 ranjith_qualiantech_com Relationship added related to 0038333
2018-06-13 15:22 aaroncalero Note Added: 0105128
2018-06-13 15:22 aaroncalero Note Deleted: 0105128
2018-06-14 12:52 hgbot Checkin
2018-06-14 12:52 hgbot Note Added: 0105141
2018-06-14 12:52 hgbot Status scheduled => resolved
2018-06-14 12:52 hgbot Resolution open => fixed
2018-06-14 12:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^]
2018-06-14 15:58 hgbot Checkin
2018-06-14 15:58 hgbot Note Added: 0105145
2018-06-14 16:22 migueldejuana Note Added: 0105147
2018-06-14 16:22 migueldejuana Status resolved => new
2018-06-14 16:22 migueldejuana Resolution fixed => open
2018-06-15 08:11 ranjith_qualiantech_com Status new => scheduled
2018-06-15 10:32 hgbot Checkin
2018-06-15 10:32 hgbot Note Added: 0105169
2018-06-15 10:32 hgbot Status scheduled => resolved
2018-06-15 10:32 hgbot Resolution open => fixed
2018-06-15 10:32 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79ca02c60af2e3458de7db970271a2b681e5e90c [^]
2018-06-15 11:01 hgbot Checkin
2018-06-15 11:01 hgbot Note Added: 0105174
2018-06-15 11:54 migueldejuana Review Assigned To => migueldejuana
2018-06-15 11:54 migueldejuana Note Added: 0105178
2018-06-15 11:54 migueldejuana Status resolved => closed
2018-07-26 10:29 ranjith_qualiantech_com Relationship added causes 0038904

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker