Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038750Retail ModulesWeb POSpublic2018-06-13 13:232018-06-15 11:54
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038750: It is possible to generate overpayments in cash payment methods
DescriptionIt is possible to generate overpayments in cash payment methods.
When a layaway with a cash prepayment is loaded in web pos, and a second cash payment is added, if this second payment is greater that the pending amount, but lower than the total amount of the ticket, instead of generating change for the customer, an overpayment is generated.
Steps To ReproduceLogin in web pos.
Create a new Layaway (Menu > Layaway this receipt)
Add an avalanche transceiver (total: 150.50€)
Click on the Total Amount button to go to the payments tab
Add a 50€ payment in Cash
Click on Layaway to synchronize the ticket.
Go to the Menu > Open Receipts and load the layaway again.
Click on the Total Amount button to go to the payments tab.
Add a 110€ payment in Cash.
verify that the payment tab shows a "9.50€ overpayment." message instead of a "9.50€ remaining to return." message.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038333 closed ranjith_qualiantech_com Wrong Payment Details created in backend when paying Layaway with Cash first then overpaying with Digital Coupon 
causes defect 0038904 closed ranjith_qualiantech_com Change was not caluclated properly when payments exceeds pending amount 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-13 13:23aaroncaleroNew Issue
2018-06-13 13:23aaroncaleroAssigned To => Retail
2018-06-13 13:23aaroncaleroResolution time => 1530050400
2018-06-13 13:23aaroncaleroTriggers an Emergency Pack => No
2018-06-13 13:26ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-06-13 13:26ranjith_qualiantech_comStatusnew => scheduled
2018-06-13 15:16ranjith_qualiantech_comRelationship addedrelated to 0038333
2018-06-13 15:22aaroncaleroNote Added: 0105128
2018-06-13 15:22aaroncaleroNote Deleted: 0105128
2018-06-14 12:52hgbotCheckin
2018-06-14 12:52hgbotNote Added: 0105141
2018-06-14 12:52hgbotStatusscheduled => resolved
2018-06-14 12:52hgbotResolutionopen => fixed
2018-06-14 12:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^]
2018-06-14 15:58hgbotCheckin
2018-06-14 15:58hgbotNote Added: 0105145
2018-06-14 16:22migueldejuanaNote Added: 0105147
2018-06-14 16:22migueldejuanaStatusresolved => new
2018-06-14 16:22migueldejuanaResolutionfixed => open
2018-06-15 08:11ranjith_qualiantech_comStatusnew => scheduled
2018-06-15 10:32hgbotCheckin
2018-06-15 10:32hgbotNote Added: 0105169
2018-06-15 10:32hgbotStatusscheduled => resolved
2018-06-15 10:32hgbotResolutionopen => fixed
2018-06-15 10:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79ca02c60af2e3458de7db970271a2b681e5e90c [^]
2018-06-15 11:01hgbotCheckin
2018-06-15 11:01hgbotNote Added: 0105174
2018-06-15 11:54migueldejuanaReview Assigned To => migueldejuana
2018-06-15 11:54migueldejuanaNote Added: 0105178
2018-06-15 11:54migueldejuanaStatusresolved => closed
2018-07-26 10:29ranjith_qualiantech_comRelationship addedcauses 0038904

Notes
(0105141)
hgbot   
2018-06-14 12:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 250d589a586b180e0b7d5888fa13a2b138e9b570
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 14 16:22:25 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/250d589a586b180e0b7d5888fa13a2b138e9b570 [^]

Fixed issue 38750 : Change should not be calculated based on Prepayments

* If Cash payments (includes prepayment) is higher than Total Amount, then Extra Cash should be given as Change
* If Card payments (includes prepayment) is higher than Total Amount, then Extra Cash should be considred as Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105145)
hgbot   
2018-06-14 15:58   
Repository: tools/automation/pi-mobile
Changeset: 43d7412fb7526de2b23a44dbc9c89fdae0d6bcb9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 14 16:22:44 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/43d7412fb7526de2b23a44dbc9c89fdae0d6bcb9 [^]

Verifies issue 38750 : Added automated test 'I38750_VerfiyCashChangeOnLayaway'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38750_VerfiyCashChangeOnLayaway.java
---
(0105147)
migueldejuana   
2018-06-14 16:22   
Login in web pos.
Create a new Layaway (Menu > Layaway this receipt)
Add an avalanche transceiver (total: 150.50€)
Click on the Total Amount button to go to the payments tab
Add a 20€ payment in Cash
Click on Layaway to synchronize the ticket.
Go to the Menu > Open Receipts and load the layaway again.
Click on the Total Amount button to go to the payments tab.
Add a 20€ payment in Cash.
Add a 150$ payment in USA Cash.
verify that the payment tab shows a "3.62$ overpayment." message instead of a "3.62$ remaining to return." message.

Add a test with this case.
Play with payments and try to find another failing case
(0105169)
hgbot   
2018-06-15 10:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 79ca02c60af2e3458de7db970271a2b681e5e90c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 15 14:01:58 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79ca02c60af2e3458de7db970271a2b681e5e90c [^]

Fixed issue 38750 : Change should not be calculated based on Prepayments

* If Cash payments (includes prepayment) is higher than Total Amount, then Extra Cash should be given as Change
* If Card payments (includes prepayment) is higher than Total Amount, then Extra Cash should be considred as Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105174)
hgbot   
2018-06-15 11:01   
Repository: tools/automation/pi-mobile
Changeset: 94b31e322c0ac12276d5f69b04f93da3d78cd701
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 15 14:02:10 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/94b31e322c0ac12276d5f69b04f93da3d78cd701 [^]

Verifies issue 38750 : Modified automated test 'I38750_VerfiyCashChangeOnLayaway'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38750_VerfiyCashChangeOnLayaway.java
---
(0105178)
migueldejuana   
2018-06-15 11:54   
Tested and reviewed