Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0038700 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] Y. DBSourceManager | minor | have not tried | 2018-06-05 10:53 | 2018-06-08 10:49 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 909e2725902f | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Oracle | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | caristu | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0038700: incorrect PL inconsistency warn when exporting DB functions in Oracle | |||||||
Description | Having in a module (M1) a PL function that invokes a function with out parameters defined in another module (M2), when exporting database in Oracle, incorrect inconsistency warns are displayed in the following cases: 1. M1 is in development and M2 is not -> this always shows the warning 2. Both are in development -> it randomly displays the warning, modules are exported in an arbitrary order, the warning will be displayed if M1 is exported before M2 | |||||||
Steps To Reproduce | Case 1 1.1. In DB execute: update ad_module set isindevelopment = 'N'; update ad_module set isindevelopment = 'Y' where javapackage='org.openbravo.advpaymentmngt'; 1.2. run ant export.database -> It always displays: [exportdatabase] 37873 WARN - Warning: Some of the functions and triggers which are being exported have been detected to change if they are inserted in a PostgreSQL database again. .... The affected objects are: [exportdatabase] 37874 WARN - Function [notation=APRM_GEN_PAYMENTSCHEDULE_INV(VARCHAR); ] [exportdatabase] 37874 WARN - Function [notation=APRM_TAX_PAYMENT(VARCHAR); ] Case 2 2.1. In DB execute: update ad_module set isindevelopment = 'Y'; 2.2. run ant export.database -> It will randomly, if Advanced Payables and Receivables Mngmt module is exported before than Core, display: [exportdatabase] 37873 WARN - Warning: Some of the functions and triggers which are being exported have been detected to change if they are inserted in a PostgreSQL database again. .... The affected objects are: [exportdatabase] 37874 WARN - Function [notation=APRM_GEN_PAYMENTSCHEDULE_INV(VARCHAR); ] [exportdatabase] 37874 WARN - Function [notation=APRM_TAX_PAYMENT(VARCHAR); ] | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0104933) hgbot (developer) 2018-06-05 11:29 |
Repository: erp/devel/dbsm-main Changeset: 93a4baed78ec38ca75b75ee84a150056349f7f21 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jun 05 11:12:15 2018 +0200 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/93a4baed78ec38ca75b75ee84a150056349f7f21 [^] related to bug 38700: incorrect PL inconsistency warn in ORA - Preserve order when exporting modules in order to get more repeatable builds - Do not create unnecessary PostgrePLSQLFunctionTranslation objects - Do not add new function patterns on each module, reset them --- M src/org/apache/ddlutils/platform/oracle/OraclePlatform.java M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java M src/org/openbravo/ddlutils/util/DBSMOBUtil.java --- |
(0104934) hgbot (developer) 2018-06-05 11:29 |
Repository: erp/devel/dbsm-main Changeset: c4c95f5f7bc2e87c74308181dc86d16692f9df8f Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jun 05 11:27:30 2018 +0200 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/c4c95f5f7bc2e87c74308181dc86d16692f9df8f [^] fixed bug bug 38700: incorrect PL inconsistency warn in ORA When generating patterns to standardardize invocations to PL functions with output parameters, take into account all functions, not just the ones defined in current module. --- M src/org/apache/ddlutils/platform/oracle/OraclePlatform.java --- |
(0104935) hgbot (developer) 2018-06-05 11:29 |
Repository: erp/devel/pi Changeset: 909e2725902fcab8b27fbb7c8e17292e18675768 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jun 05 11:29:06 2018 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/909e2725902fcab8b27fbb7c8e17292e18675768 [^] fixed bug bug 38700: incorrect PL inconsistency warn in ORA When generating patterns to standardardize invocations to PL functions with output parameters, take into account all functions, not just the ones defined in current module. --- M src-db/database/lib/dbsourcemanager.jar --- |
(0104960) hudsonbot (viewer) 2018-06-05 17:29 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8317f2f73d00 [^] Maturity status: Test |
(0105030) caristu (viewer) 2018-06-08 10:49 |
Code reviewed + tested OK. |
![]() |
|||
Date Modified | Username | Field | Change |
2018-06-05 10:53 | alostale | New Issue | |
2018-06-05 10:53 | alostale | Assigned To | => alostale |
2018-06-05 10:53 | alostale | OBNetwork customer | => No |
2018-06-05 10:53 | alostale | Modules | => Core |
2018-06-05 10:53 | alostale | Triggers an Emergency Pack | => No |
2018-06-05 11:29 | hgbot | Checkin | |
2018-06-05 11:29 | hgbot | Note Added: 0104933 | |
2018-06-05 11:29 | hgbot | Checkin | |
2018-06-05 11:29 | hgbot | Note Added: 0104934 | |
2018-06-05 11:29 | hgbot | Checkin | |
2018-06-05 11:29 | hgbot | Note Added: 0104935 | |
2018-06-05 13:05 | alostale | Review Assigned To | => caristu |
2018-06-05 13:05 | alostale | Status | new => scheduled |
2018-06-05 13:06 | alostale | Status | scheduled => resolved |
2018-06-05 13:06 | alostale | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/909e2725902fcab8b27fbb7c8e17292e18675768 [^] |
2018-06-05 13:06 | alostale | Resolution | open => fixed |
2018-06-05 17:29 | hudsonbot | Checkin | |
2018-06-05 17:29 | hudsonbot | Note Added: 0104960 | |
2018-06-08 10:49 | caristu | Note Added: 0105030 | |
2018-06-08 10:49 | caristu | Status | resolved => closed |
2018-06-08 10:49 | caristu | Fixed in Version | => 3.0PR18Q3 |
Copyright © 2000 - 2009 MantisBT Group |