Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038700Openbravo ERPY. DBSourceManagerpublic2018-06-05 10:532018-06-08 10:49
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038700: incorrect PL inconsistency warn when exporting DB functions in Oracle
DescriptionHaving in a module (M1) a PL function that invokes a function with out parameters defined in another module (M2), when exporting database in Oracle, incorrect inconsistency warns are displayed in the following cases:

1. M1 is in development and M2 is not -> this always shows the warning
2. Both are in development -> it randomly displays the warning, modules are exported in an arbitrary order, the warning will be displayed if M1 is exported before M2
Steps To ReproduceCase 1
1.1. In DB execute:
  update ad_module set isindevelopment = 'N';
  update ad_module set isindevelopment = 'Y' where javapackage='org.openbravo.advpaymentmngt';
1.2. run ant export.database
  -> It always displays:
   [exportdatabase] 37873 WARN - Warning: Some of the functions and triggers which are being exported have been detected to change if they are inserted in a PostgreSQL database again. .... The affected objects are:
  [exportdatabase] 37874 WARN - Function [notation=APRM_GEN_PAYMENTSCHEDULE_INV(VARCHAR); ]
  [exportdatabase] 37874 WARN - Function [notation=APRM_TAX_PAYMENT(VARCHAR); ]


Case 2
2.1. In DB execute:
  update ad_module set isindevelopment = 'Y';
2.2. run ant export.database
  -> It will randomly, if Advanced Payables and Receivables Mngmt module is exported before than Core, display:
   [exportdatabase] 37873 WARN - Warning: Some of the functions and triggers which are being exported have been detected to change if they are inserted in a PostgreSQL database again. .... The affected objects are:
  [exportdatabase] 37874 WARN - Function [notation=APRM_GEN_PAYMENTSCHEDULE_INV(VARCHAR); ]
  [exportdatabase] 37874 WARN - Function [notation=APRM_TAX_PAYMENT(VARCHAR); ]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-05 10:53alostaleNew Issue
2018-06-05 10:53alostaleAssigned To => alostale
2018-06-05 10:53alostaleOBNetwork customer => No
2018-06-05 10:53alostaleModules => Core
2018-06-05 10:53alostaleTriggers an Emergency Pack => No
2018-06-05 11:29hgbotCheckin
2018-06-05 11:29hgbotNote Added: 0104933
2018-06-05 11:29hgbotCheckin
2018-06-05 11:29hgbotNote Added: 0104934
2018-06-05 11:29hgbotCheckin
2018-06-05 11:29hgbotNote Added: 0104935
2018-06-05 13:05alostaleReview Assigned To => caristu
2018-06-05 13:05alostaleStatusnew => scheduled
2018-06-05 13:06alostaleStatusscheduled => resolved
2018-06-05 13:06alostaleFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/909e2725902fcab8b27fbb7c8e17292e18675768 [^]
2018-06-05 13:06alostaleResolutionopen => fixed
2018-06-05 17:29hudsonbotCheckin
2018-06-05 17:29hudsonbotNote Added: 0104960
2018-06-08 10:49caristuNote Added: 0105030
2018-06-08 10:49caristuStatusresolved => closed
2018-06-08 10:49caristuFixed in Version => 3.0PR18Q3

Notes
(0104933)
hgbot   
2018-06-05 11:29   
Repository: erp/devel/dbsm-main
Changeset: 93a4baed78ec38ca75b75ee84a150056349f7f21
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jun 05 11:12:15 2018 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/93a4baed78ec38ca75b75ee84a150056349f7f21 [^]

related to bug 38700: incorrect PL inconsistency warn in ORA

  - Preserve order when exporting modules in order to get more repeatable builds
  - Do not create unnecessary PostgrePLSQLFunctionTranslation objects
  - Do not add new function patterns on each module, reset them

---
M src/org/apache/ddlutils/platform/oracle/OraclePlatform.java
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
(0104934)
hgbot   
2018-06-05 11:29   
Repository: erp/devel/dbsm-main
Changeset: c4c95f5f7bc2e87c74308181dc86d16692f9df8f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jun 05 11:27:30 2018 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/c4c95f5f7bc2e87c74308181dc86d16692f9df8f [^]

fixed bug bug 38700: incorrect PL inconsistency warn in ORA

  When generating patterns to standardardize invocations to PL functions with
  output parameters, take into account all functions, not just the ones defined
  in current module.

---
M src/org/apache/ddlutils/platform/oracle/OraclePlatform.java
---
(0104935)
hgbot   
2018-06-05 11:29   
Repository: erp/devel/pi
Changeset: 909e2725902fcab8b27fbb7c8e17292e18675768
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jun 05 11:29:06 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/909e2725902fcab8b27fbb7c8e17292e18675768 [^]

fixed bug bug 38700: incorrect PL inconsistency warn in ORA

  When generating patterns to standardardize invocations to PL functions with
  output parameters, take into account all functions, not just the ones defined
  in current module.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0104960)
hudsonbot   
2018-06-05 17:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8317f2f73d00 [^]
Maturity status: Test
(0105030)
caristu   
2018-06-08 10:49   
Code reviewed + tested OK.