Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038692
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2018-06-04 12:372018-06-22 14:18
ReporterjavietxeView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR18Q3
StatusclosedFix in branchFixed in SCM revision77ac4acecd1f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038692: SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property

DescriptionWith the change introduced in https://issues.openbravo.com/view.php?id=37727, [^] the loaded property has to be equal to the last updated date from the order. As the data is coming from external systems, is very likely to have differences in the data, so the payment will be rejected.
Steps To ReproduceAdd a payment from the external order loader with date older than the last modification of the order.
Proposed SolutionThe proposed solution is to disable the concurrency check in the external order loader requests, because we cannot assume that the external tools will be able to send the originally loaded updated from the original order.

(Implemented in the attached patch)
TagsNo tags attached.
Attached Filesdiff file icon noConcurrencyExternalOrderLoader.diff [^] (1,539 bytes) 2018-06-04 12:37 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0038819RR18Q2.1 closedmarvintm SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property 

-  Notes
(0104926)
hgbot (developer)
2018-06-04 19:24

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 04 19:24:02 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6 [^]

Fixed issue 38692. The payments from ecommerce are not integrated because of the loaded property.
Concurrency check will be disabled in the ExternalOrderLoader because we cannot guarantee that the external tools will be able to send the same 'loaded' property as the WebPOS in all cases.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0105191)
migueldejuana (developer)
2018-06-18 09:32

Reviewed

- Issue History
Date Modified Username Field Change
2018-06-04 12:37 javietxe New Issue
2018-06-04 12:37 javietxe Assigned To => marvintm
2018-06-04 12:37 javietxe File Added: noConcurrencyExternalOrderLoader.diff
2018-06-04 12:37 javietxe Resolution time => 1529272800
2018-06-04 12:37 javietxe Triggers an Emergency Pack => No
2018-06-04 12:37 javietxe Proposed Solution updated
2018-06-04 12:46 marvintm Proposed Solution updated
2018-06-04 19:18 marvintm Status new => scheduled
2018-06-04 19:24 hgbot Checkin
2018-06-04 19:24 hgbot Note Added: 0104926
2018-06-04 19:24 hgbot Status scheduled => resolved
2018-06-04 19:24 hgbot Resolution open => fixed
2018-06-04 19:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6 [^]
2018-06-18 09:32 migueldejuana Review Assigned To => migueldejuana
2018-06-18 09:32 migueldejuana Note Added: 0105191
2018-06-18 09:32 migueldejuana Status resolved => closed
2018-06-22 14:16 marvintm Status closed => new
2018-06-22 14:16 marvintm Resolution fixed => open
2018-06-22 14:17 marvintm Status new => scheduled
2018-06-22 14:17 marvintm Status scheduled => resolved
2018-06-22 14:17 marvintm Fixed in Version => RR18Q3
2018-06-22 14:17 marvintm Resolution open => fixed
2018-06-22 14:17 marvintm Status resolved => closed
2018-06-22 14:17 marvintm Status closed => new
2018-06-22 14:17 marvintm Resolution fixed => open
2018-06-22 14:17 marvintm Fixed in Version RR18Q3 =>
2018-06-22 14:17 marvintm Status new => scheduled
2018-06-22 14:18 marvintm Status scheduled => resolved
2018-06-22 14:18 marvintm Fixed in Version => RR18Q3
2018-06-22 14:18 marvintm Resolution open => fixed
2018-06-22 14:18 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker