Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038692Retail ModulesWeb POSpublic2018-06-04 12:372018-06-22 14:18
Reporterjavietxe 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038692: SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property
DescriptionWith the change introduced in https://issues.openbravo.com/view.php?id=37727, [^] the loaded property has to be equal to the last updated date from the order. As the data is coming from external systems, is very likely to have differences in the data, so the payment will be rejected.
Steps To ReproduceAdd a payment from the external order loader with date older than the last modification of the order.
Proposed SolutionThe proposed solution is to disable the concurrency check in the external order loader requests, because we cannot assume that the external tools will be able to send the originally loaded updated from the original order.

(Implemented in the attached patch)
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0038819RR18Q2.1 closed marvintm SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property 
Attached Filesdiff noConcurrencyExternalOrderLoader.diff (1,539) 2018-06-04 12:37
https://issues.openbravo.com/file_download.php?file_id=11823&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-06-04 12:37javietxeNew Issue
2018-06-04 12:37javietxeAssigned To => marvintm
2018-06-04 12:37javietxeFile Added: noConcurrencyExternalOrderLoader.diff
2018-06-04 12:37javietxeOBNetwork customer => Yes
2018-06-04 12:37javietxeResolution time => 1529272800
2018-06-04 12:37javietxeTriggers an Emergency Pack => No
2018-06-04 12:37javietxeProposed Solution updated
2018-06-04 12:46marvintmProposed Solution updated
2018-06-04 19:18marvintmStatusnew => scheduled
2018-06-04 19:24hgbotCheckin
2018-06-04 19:24hgbotNote Added: 0104926
2018-06-04 19:24hgbotStatusscheduled => resolved
2018-06-04 19:24hgbotResolutionopen => fixed
2018-06-04 19:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6 [^]
2018-06-18 09:32migueldejuanaReview Assigned To => migueldejuana
2018-06-18 09:32migueldejuanaNote Added: 0105191
2018-06-18 09:32migueldejuanaStatusresolved => closed
2018-06-22 14:16marvintmStatusclosed => new
2018-06-22 14:16marvintmResolutionfixed => open
2018-06-22 14:17marvintmStatusnew => scheduled
2018-06-22 14:17marvintmStatusscheduled => resolved
2018-06-22 14:17marvintmFixed in Version => RR18Q3
2018-06-22 14:17marvintmResolutionopen => fixed
2018-06-22 14:17marvintmStatusresolved => closed
2018-06-22 14:17marvintmStatusclosed => new
2018-06-22 14:17marvintmResolutionfixed => open
2018-06-22 14:17marvintmFixed in VersionRR18Q3 =>
2018-06-22 14:17marvintmStatusnew => scheduled
2018-06-22 14:18marvintmStatusscheduled => resolved
2018-06-22 14:18marvintmFixed in Version => RR18Q3
2018-06-22 14:18marvintmResolutionopen => fixed
2018-06-22 14:18marvintmStatusresolved => closed

Notes
(0104926)
hgbot   
2018-06-04 19:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 04 19:24:02 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6 [^]

Fixed issue 38692. The payments from ecommerce are not integrated because of the loaded property.
Concurrency check will be disabled in the ExternalOrderLoader because we cannot guarantee that the external tools will be able to send the same 'loaded' property as the WebPOS in all cases.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0105191)
migueldejuana   
2018-06-18 09:32   
Reviewed