Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038506
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServermajorhave not tried2018-05-08 22:552018-06-14 09:53
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione3aebeb2286b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting

DescriptionWhen the ss is online and cs has sync errors there are specific conditions:
- some non-white listed services are still forwarded to cs, these are the ones which can not run in offline mode.
- do not transition to offline eventhough it is requested by the code

When the SS starts and there exist sync errors from the start then do not start in offline mode, but start in online mode.
When starting and seeing that there are version differences and also sync errors, even then do not go offline

Steps To ReproduceSee transition code
Proposed SolutionCheck the symmetric ds incoming error table for errors and use this check when transitioning to offline, when starting ss and when calling whitelisted service.
TagsNo tags attached.
Attached Filesdiff file icon 38506-core.diff [^] (800 bytes) 2018-06-13 00:53 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0038755 closedmtaal Product search in remote mode does not show the error message returned from the server 

-  Notes
(0104466)
hgbot (developer)
2018-05-11 09:14

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: eba18b3cb6004b541c30d4d40fabbef0508fcde7
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 09:14:06 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eba18b3cb6004b541c30d4d40fabbef0508fcde7 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Added extension point to allow prevening going offline

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0104468)
hgbot (developer)
2018-05-11 11:52

Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 05b1c4bf43fa6e3c488ee5cf2e4bec93113f166c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 11:52:45 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/05b1c4bf43fa6e3c488ee5cf2e4bec93113f166c [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Do not start in offline mode when there are sync errors.
Adapted the query to check for incoming errors to use the error flag as it is indexed

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/util/ReplicationUtils.java
---
(0104472)
hgbot (developer)
2018-05-11 13:36

Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: e3aebeb2286b7d28c6502a13b727c4ee6aaf292e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 13:36:23 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/e3aebeb2286b7d28c6502a13b727c4ee6aaf292e [^]

Fixes issue 38506: Do not transition to offline if there are sync errors
Implement an extension to prevent transition to offline if there are incoming sync errors or version differences
Do not go offline when starting if there are sync errors.
Only use always-local-white-list services if there are version differences or incoming errors

---
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/StoreServerVersionHandler.java
M src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java
A src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java
---
(0105104)
hgbot (developer)
2018-06-13 00:52

Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 9989f02e3befbca31ac173e91e24927f72826c20
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 13 00:52:13 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/9989f02e3befbca31ac173e91e24927f72826c20 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Added log statements

---
M src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java
---
(0105137)
hgbot (developer)
2018-06-14 09:49

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d999c3a2c9d42de8a3fea3695b882131e4004b73
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 14 09:49:14 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d999c3a2c9d42de8a3fea3695b882131e4004b73 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Log the class of the handler which prevents going offline

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0105138)
AugustoMauch (manager)
2018-06-14 09:53

Code reviewed and verified

- Issue History
Date Modified Username Field Change
2018-05-08 22:55 mtaal New Issue
2018-05-08 22:55 mtaal Assigned To => mtaal
2018-05-08 22:55 mtaal Triggers an Emergency Pack => No
2018-05-10 15:36 mtaal Description Updated View Revisions
2018-05-10 15:36 mtaal Proposed Solution updated
2018-05-11 09:14 hgbot Checkin
2018-05-11 09:14 hgbot Note Added: 0104466
2018-05-11 11:52 hgbot Checkin
2018-05-11 11:52 hgbot Note Added: 0104468
2018-05-11 13:36 hgbot Checkin
2018-05-11 13:36 hgbot Note Added: 0104472
2018-05-11 13:36 hgbot Status new => resolved
2018-05-11 13:36 hgbot Resolution open => fixed
2018-05-11 13:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/e3aebeb2286b7d28c6502a13b727c4ee6aaf292e [^]
2018-05-11 13:37 mtaal Review Assigned To => AugustoMauch
2018-05-14 09:46 rafademiguel Issue Monitored: rafademiguel
2018-06-12 12:33 mtaal Description Updated View Revisions
2018-06-13 00:52 hgbot Checkin
2018-06-13 00:52 hgbot Note Added: 0105104
2018-06-13 00:53 mtaal File Added: 38506-core.diff
2018-06-14 09:49 hgbot Checkin
2018-06-14 09:49 hgbot Note Added: 0105137
2018-06-14 09:53 AugustoMauch Note Added: 0105138
2018-06-14 09:53 AugustoMauch Status resolved => closed
2018-06-14 10:24 mtaal Relationship added related to 0038755


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker