Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038506Retail ModulesStoreServerpublic2018-05-08 22:552018-06-14 09:53
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
DescriptionWhen the ss is online and cs has sync errors there are specific conditions:
- some non-white listed services are still forwarded to cs, these are the ones which can not run in offline mode.
- do not transition to offline eventhough it is requested by the code

When the SS starts and there exist sync errors from the start then do not start in offline mode, but start in online mode.
When starting and seeing that there are version differences and also sync errors, even then do not go offline

Steps To ReproduceSee transition code
Proposed SolutionCheck the symmetric ds incoming error table for errors and use this check when transitioning to offline, when starting ss and when calling whitelisted service.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038755 closed mtaal Product search in remote mode does not show the error message returned from the server 
Attached Filesdiff 38506-core.diff (800) 2018-06-13 00:53
https://issues.openbravo.com/file_download.php?file_id=11854&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-05-08 22:55mtaalNew Issue
2018-05-08 22:55mtaalAssigned To => mtaal
2018-05-08 22:55mtaalTriggers an Emergency Pack => No
2018-05-10 15:36mtaalDescription Updatedbug_revision_view_page.php?rev_id=17120#r17120
2018-05-10 15:36mtaalProposed Solution updated
2018-05-11 09:14hgbotCheckin
2018-05-11 09:14hgbotNote Added: 0104466
2018-05-11 11:52hgbotCheckin
2018-05-11 11:52hgbotNote Added: 0104468
2018-05-11 13:36hgbotCheckin
2018-05-11 13:36hgbotNote Added: 0104472
2018-05-11 13:36hgbotStatusnew => resolved
2018-05-11 13:36hgbotResolutionopen => fixed
2018-05-11 13:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/e3aebeb2286b7d28c6502a13b727c4ee6aaf292e [^]
2018-05-11 13:37mtaalReview Assigned To => AugustoMauch
2018-05-14 09:46rafademiguelIssue Monitored: rafademiguel
2018-06-12 12:33mtaalDescription Updatedbug_revision_view_page.php?rev_id=17285#r17285
2018-06-13 00:52hgbotCheckin
2018-06-13 00:52hgbotNote Added: 0105104
2018-06-13 00:53mtaalFile Added: 38506-core.diff
2018-06-14 09:49hgbotCheckin
2018-06-14 09:49hgbotNote Added: 0105137
2018-06-14 09:53AugustoMauchNote Added: 0105138
2018-06-14 09:53AugustoMauchStatusresolved => closed
2018-06-14 10:24mtaalRelationship addedrelated to 0038755

Notes
(0104466)
hgbot   
2018-05-11 09:14   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: eba18b3cb6004b541c30d4d40fabbef0508fcde7
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 09:14:06 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/eba18b3cb6004b541c30d4d40fabbef0508fcde7 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Added extension point to allow prevening going offline

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0104468)
hgbot   
2018-05-11 11:52   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 05b1c4bf43fa6e3c488ee5cf2e4bec93113f166c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 11:52:45 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/05b1c4bf43fa6e3c488ee5cf2e4bec93113f166c [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Do not start in offline mode when there are sync errors.
Adapted the query to check for incoming errors to use the error flag as it is indexed

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/util/ReplicationUtils.java
---
(0104472)
hgbot   
2018-05-11 13:36   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: e3aebeb2286b7d28c6502a13b727c4ee6aaf292e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 11 13:36:23 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/e3aebeb2286b7d28c6502a13b727c4ee6aaf292e [^]

Fixes issue 38506: Do not transition to offline if there are sync errors
Implement an extension to prevent transition to offline if there are incoming sync errors or version differences
Do not go offline when starting if there are sync errors.
Only use always-local-white-list services if there are version differences or incoming errors

---
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/StoreServerVersionHandler.java
M src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java
A src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java
---
(0105104)
hgbot   
2018-06-13 00:52   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 9989f02e3befbca31ac173e91e24927f72826c20
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 13 00:52:13 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/9989f02e3befbca31ac173e91e24927f72826c20 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Added log statements

---
M src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java
---
(0105137)
hgbot   
2018-06-14 09:49   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d999c3a2c9d42de8a3fea3695b882131e4004b73
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 14 09:49:14 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d999c3a2c9d42de8a3fea3695b882131e4004b73 [^]

Related to issue 38506: Do not transition to offline if there are sync errors, then stay in special state which does limited whitelisting
Log the class of the handler which prevents going offline

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0105138)
AugustoMauch   
2018-06-14 09:53   
Code reviewed and verified