|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|backport||[Retail Modules] Web POS||major||always||2018-04-27 13:53||2018-05-10 12:03|
|Priority||immediate||Resolution||fixed||Fixed in Version||RR18Q1.3|
|Status||closed||Fix in branch||Fixed in SCM revision||239e16d6cc55|
|OS Version||Database version||Ant version|
|Product Version||SCM revision|
|Review Assigned To||marvintm|
|Regression introduced in release||main|
|Regression introduced by commit||http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4fb9c07eb350e512bafe7547473d226da3b7efa [^]|
|Triggers an Emergency Pack||No|
0038468: getPaymentAmount() is not being rounded and causes ticket is identified as "hasReceiptChange"=true
|Description||When ticket is paid using higher amount but change is given in same currency, it should not be identified as "change"|
|Steps To Reproduce||0. Access Terminal, select any product and set price=1500.40|
1. Pay ticket setting amount=1550 (so change of 49.6 is calculated) and press done
2. Access backoffice to review the sales order and realize that payment plan information is incorrect as change amount has been identified as outstanding amount. Also, navigate to Payment document and realize that details are incorrect as gl item has been used when it should not.
|Tags||No tags attached.|
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed May 02 12:26:25 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1.3/org.openbravo.retail.posterminal/rev/239e16d6cc55bd44814cf9a1147c04c2a749abca [^]
Fixes issue 38468: Fix precision of payment amount read from json in the order loader.
Payment amount when read from json was passed to Double and then to BigDecimal which produce precision problems.
The precision problems makes that the check if there is change to be true, when in really there isn't change,
which produce the behaviour reported in the issue.
Now readed as string from json and passed directly to BigDecimal.
|2018-04-27 14:01||marvintm||Type||defect => backport|
|2018-04-27 14:01||marvintm||Target Version||=> RR18Q1.4|
|2018-05-02 14:12||hgbot||Note Added: 0104202|
|2018-05-02 14:12||hgbot||Status||scheduled => resolved|
|2018-05-02 14:12||hgbot||Resolution||open => fixed|
|2018-05-02 14:12||hgbot||Fixed in SCM revision||=> http://code.openbravo.com/retail/backports/3.0RR18Q1.3/org.openbravo.retail.posterminal/rev/239e16d6cc55bd44814cf9a1147c04c2a749abca [^]|
|2018-05-02 14:13||gorka_gil||Target Version||RR18Q1.4 => RR18Q1.3|
|2018-05-04 14:45||marvintm||Review Assigned To||=> marvintm|
|2018-05-04 14:45||marvintm||Status||resolved => closed|
|2018-05-04 14:45||marvintm||Fixed in Version||=> RR18Q1.3|
|2018-05-10 12:03||gorka_gil||Assigned To||Retail => gorka_gil|
|Copyright © 2000 - 2009 MantisBT Group|